Fixing dragConstraints={ref} with active layout animations
#2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvh
reviewed
Jun 19, 2024
Comment on lines
+237
to
+239
| .wait(200) | ||
| .trigger("pointermove", 300, 300, { force: true }) | ||
| .wait(50) | ||
| .wait(200) |
There was a problem hiding this comment.
The layout animation I added is like 100 - 200ms long so this delay has to be long enough for them to trigger and break the measurements
nvh
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/framer/company/issues/29798
Ensures that draggable components are always remeasured without their transform.