Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added commands to list vpx contents and script. #112

Merged
merged 13 commits into from
Sep 20, 2023

Conversation

MarijnStevens
Copy link
Contributor

./vpxtools ls

list the files inside an vpx without extracting.

@MarijnStevens MarijnStevens changed the title Added command to list vpx contents Added commands to list vpx contents and script. Sep 20, 2023
Copy link
Owner

@francisdb francisdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor improvements

);
// TODO -extract_gameitems

for file_path in files {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep console io in main?

So returning the files here and println in main, that way we can test this function

src/vpx/mod.rs Outdated Show resolved Hide resolved
@francisdb
Copy link
Owner

francisdb commented Sep 20, 2023

and looks like cargo fmt was not applied

@MarijnStevens
Copy link
Contributor Author

Updated commands to println in main.rs

.vscode/launch.json Outdated Show resolved Hide resolved
@francisdb francisdb merged commit 284f23a into francisdb:main Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants