Fix issues #23
Merged
Fix issues #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix issue frankenstein91#20
This hopefully fixes issue frankenstein91#21 Untested though
Proper gnome keymap setting (frankenstein91#21) Improved dconf settings for: - Disabling sleep (frankenstein91#22) - Enabling appindicator (frankenstein91#19)
Undo 980cda2 Correct dconf key
Add "auto" NM connection profile Add after reboot to not risk anything Also remove the temporary profile
|
Also just added sing a auto (DHCP) connection after reboot and deleting the temporary one |
|
#22 not fixed |
|
#21 not fixed |
|
#20 is working now |
|
#19 is fixed and activ |
|
|
|
the value #21 |
As suggested in PR frankenstein91#23 For issue frankenstein91#22
In gnome_shell role Add tasks to find out keymap Set keymap if var is not empty
In order to at least pass syntax check
|
I made an attempt to fix the remaining issues. Also Added fix for linter syntax error (that came up while syntax actually was correct). |
As the linter said to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the following issues (not tested though):
Not so sure with the last one, I haven't really changed much. But it should work.