Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node-sass xcode rebuild issue #225

Merged
merged 1 commit into from
May 22, 2019
Merged

fix: node-sass xcode rebuild issue #225

merged 1 commit into from
May 22, 2019

Conversation

scmmishra
Copy link
Contributor

@scmmishra scmmishra commented May 22, 2019 •
edited
Loading

Upgrading node-sass to 4.12.0
Implements the fix from node-gyp, fixed here nodejs/node-gyp#1455

RegExp bug in Node 10's xcode_emulation.py

version = re.match(r'(\\d\\.\\d\\.?\\d*)', version).groups()[0]
AttributeError: 'NoneType' object has no attribute 'groups'

@coveralls
Copy link

coveralls commented May 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 82

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.158%
Totals Coverage Status
Change from base Build 81: 0.0%
Covered Lines: 29
Relevant Lines: 62
💛 - Coveralls

@scmmishra scmmishra merged commit 86d16b1 into frappe:master May 22, 2019
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scmmishra @coveralls