Skip to content

Commit

Permalink
fix: incorrect usage get_cached_value on single doctypes
Browse files Browse the repository at this point in the history
(cherry picked from commit ba15810)
  • Loading branch information
ruthra-kumar committed Aug 1, 2023
1 parent 99e7406 commit 8f72a68
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion erpnext/accounts/deferred_revenue.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def book_deferred_income_or_expense(doc, deferred_process, posting_date=None):
"enable_deferred_revenue" if doc.doctype == "Sales Invoice" else "enable_deferred_expense"
)

accounts_frozen_upto = frappe.get_cached_value("Accounts Settings", "None", "acc_frozen_upto")
accounts_frozen_upto = frappe.db.get_single_value("Accounts Settings", "acc_frozen_upto")

def _book_deferred_revenue_or_expense(
item,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def validate_with_previous_doc(self):
)

if (
cint(frappe.get_cached_value("Buying Settings", "None", "maintain_same_rate"))
cint(frappe.db.get_single_value("Buying Settings", "maintain_same_rate"))
and not self.is_return
and not self.is_internal_supplier
):
Expand Down
2 changes: 1 addition & 1 deletion erpnext/stock/doctype/price_list/price_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def check_impact_on_shopping_cart(self):

doc_before_save = self.get_doc_before_save()
currency_changed = self.currency != doc_before_save.currency
affects_cart = self.name == frappe.get_cached_value("E Commerce Settings", None, "price_list")
affects_cart = self.name == frappe.db.get_single_value("E Commerce Settings", "price_list")

if currency_changed and affects_cart:
validate_cart_settings()
Expand Down

0 comments on commit 8f72a68

Please sign in to comment.