Skip to content

Commit

Permalink
Merge pull request #34652 from frappe/mergify/bp/version-14-hotfix/pr…
Browse files Browse the repository at this point in the history
…-34648

fix: serial no with zero quantity issue in stock reco (backport #34648)
  • Loading branch information
rohitwaghchaure committed Mar 30, 2023
2 parents 4dfc660 + f47be46 commit bae476c
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from typing import Optional

import frappe
from frappe import _, msgprint
from frappe import _, bold, msgprint
from frappe.utils import cint, cstr, flt

import erpnext
Expand Down Expand Up @@ -89,7 +89,7 @@ def _changed(item):

if item_dict.get("serial_nos"):
item.current_serial_no = item_dict.get("serial_nos")
if self.purpose == "Stock Reconciliation" and not item.serial_no:
if self.purpose == "Stock Reconciliation" and not item.serial_no and item.qty:
item.serial_no = item.current_serial_no

item.current_qty = item_dict.get("qty")
Expand Down Expand Up @@ -140,6 +140,14 @@ def _get_msg(row_num, msg):

self.validate_item(row.item_code, row)

if row.serial_no and not row.qty:
self.validation_messages.append(
_get_msg(
row_num,
f"Quantity should not be zero for the {bold(row.item_code)} since serial nos are specified",
)
)

# validate warehouse
if not frappe.db.get_value("Warehouse", row.warehouse):
self.validation_messages.append(_get_msg(row_num, _("Warehouse not found in the system")))
Expand Down

0 comments on commit bae476c

Please sign in to comment.