Skip to content

Commit

Permalink
refactor(test): split into multiple test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
ruthra-kumar committed Aug 8, 2023
1 parent b00ae70 commit c74038c
Showing 1 changed file with 52 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,9 @@ def test_01_basic_functions(self):
# Assert incorrect ledger balance
self.assertNotEqual(res[0], (si.name, 100, 100))

# Submit report document
# Submit repost document
ral.save().submit()

# assert preview data is generated
preview = ral.generate_preview()
self.assertIsNotNone(preview)

# background jobs don't run on test cases. Manually triggering repost function.
start_repost(ral.name)

Expand Down Expand Up @@ -118,11 +114,10 @@ def test_02_deferred_accounting_valiations(self):

ral = frappe.new_doc("Repost Accounting Ledger")
ral.company = self.company
ral.delete_cancelled_entries = False
ral.append("vouchers", {"voucher_type": si.doctype, "voucher_no": si.name})
self.assertRaises(frappe.ValidationError, ral.save)

def test_03_pcv_validation(self):
def test_04_pcv_validation(self):
# Clear old GL entries so PCV can be submitted.
gl = frappe.qb.DocType("GL Entry")
qb.from_(gl).delete().where(gl.company == self.company).run()
Expand Down Expand Up @@ -152,6 +147,55 @@ def test_03_pcv_validation(self):

ral = frappe.new_doc("Repost Accounting Ledger")
ral.company = self.company
ral.delete_cancelled_entries = True
ral.append("vouchers", {"voucher_type": si.doctype, "voucher_no": si.name})
self.assertRaises(frappe.ValidationError, ral.save)

pcv.reload()
pcv.cancel()
pcv.delete()

def test_03_deletion_flag_and_preview_function(self):
si = create_sales_invoice(
item=self.item,
company=self.company,
customer=self.customer,
debit_to=self.debit_to,
parent_cost_center=self.cost_center,
cost_center=self.cost_center,
rate=100,
)

pe = get_payment_entry(si.doctype, si.name)
pe.save().submit()

# without deletion flag set
ral = frappe.new_doc("Repost Accounting Ledger")
ral.company = self.company
ral.delete_cancelled_entries = False
ral.append("vouchers", {"voucher_type": si.doctype, "voucher_no": si.name})
ral.append("vouchers", {"voucher_type": pe.doctype, "voucher_no": pe.name})
ral.save()

# assert preview data is generated
preview = ral.generate_preview()
self.assertIsNotNone(preview)

ral.save().submit()

# background jobs don't run on test cases. Manually triggering repost function.
start_repost(ral.name)

self.assertIsNotNone(frappe.db.exists("GL Entry", {"voucher_no": si.name, "is_cancelled": 1}))
self.assertIsNotNone(frappe.db.exists("GL Entry", {"voucher_no": pe.name, "is_cancelled": 1}))

# with deletion flag set
ral = frappe.new_doc("Repost Accounting Ledger")
ral.company = self.company
ral.delete_cancelled_entries = True
ral.append("vouchers", {"voucher_type": si.doctype, "voucher_no": si.name})
ral.append("vouchers", {"voucher_type": pe.doctype, "voucher_no": pe.name})
ral.save().submit()

start_repost(ral.name)
self.assertIsNone(frappe.db.exists("GL Entry", {"voucher_no": si.name, "is_cancelled": 1}))
self.assertIsNone(frappe.db.exists("GL Entry", {"voucher_no": pe.name, "is_cancelled": 1}))

0 comments on commit c74038c

Please sign in to comment.