chore: Code readability & check for field in row (now row itself)

frappe · Jun 16, 2022 · ea1095f · ea1095f
1 parent e817191
commit ea1095f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py
@@ -36,11 +36,12 @@ def validate(self):
 
 	def validate_duplicate_apply_on(self):
 		if self.apply_on != "Transaction":
-			field = apply_on_dict.get(self.apply_on)
-			if not field:
+			apply_on_table = apply_on_dict.get(self.apply_on)
+			if not apply_on_table:
 				return
 
-			values = [d.get(frappe.scrub(self.apply_on)) for d in self.get(field) if d]
+			apply_on_field = frappe.scrub(self.apply_on)
+			values = [d.get(apply_on_field) for d in self.get(apply_on_table) if d.get(apply_on_field)]
 			if len(values) != len(set(values)):
 				frappe.throw(_("Duplicate {0} found in the table").format(self.apply_on))