Skip to content

Commit

Permalink
test: added test case
Browse files Browse the repository at this point in the history
  • Loading branch information
rohitwaghchaure committed Jun 15, 2023
1 parent 6e19818 commit f9f6626
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
22 changes: 15 additions & 7 deletions erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
Original file line number Diff line number Diff line change
Expand Up @@ -642,13 +642,6 @@ def test_standalone_return_using_pi(self):
gle_filters={"account": "Stock In Hand - TCP1"},
)

# assert loss booked in COGS
self.assertGLEs(
return_pi,
[{"credit": 0, "debit": 200}],
gle_filters={"account": "Cost of Goods Sold - TCP1"},
)

def test_return_with_lcv(self):
from erpnext.controllers.sales_and_purchase_return import make_return_doc
from erpnext.stock.doctype.landed_cost_voucher.test_landed_cost_voucher import (
Expand Down Expand Up @@ -1671,6 +1664,21 @@ def test_batch_expiry_for_purchase_invoice(self):

self.assertTrue(return_pi.docstatus == 1)

def test_gl_entries_for_standalone_debit_note(self):
make_purchase_invoice(qty=5, rate=500, update_stock=True)

returned_inv = make_purchase_invoice(qty=-5, rate=5, update_stock=True, is_return=True)

# override the rate with valuation rate
sle = frappe.get_all(
"Stock Ledger Entry",
fields=["stock_value_difference", "actual_qty"],
filters={"voucher_no": returned_inv.name},
)[0]

rate = flt(sle.stock_value_difference) / flt(sle.actual_qty)
self.assertAlmostEqual(returned_inv.items[0].rate, rate)


def check_gl_entries(doc, voucher_no, expected_gle, posting_date):
gl_entries = frappe.db.sql(
Expand Down
2 changes: 2 additions & 0 deletions erpnext/controllers/buying_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ def create_package_for_transfer(self) -> None:
def set_rate_for_standalone_debit_note(self):
if self.get("is_return") and self.get("update_stock") and not self.return_against:
for row in self.items:

# override the rate with valuation rate
row.rate = get_incoming_rate(
{
"item_code": row.item_code,
Expand Down

0 comments on commit f9f6626

Please sign in to comment.