Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Plan currency not respected when generating Sales invoices #24781

Closed
muhaym opened this issue Mar 2, 2021 · 3 comments
Closed
Labels
bug to-validate Old issues pending validation

Comments

@muhaym
Copy link

muhaym commented Mar 2, 2021

Description of the issue

Context information (for bug reports)

Output of bench version

erpnext 12.17.0
frappe 12.14.0

Steps to reproduce the issue

  1. Create a subscription plan with a different currency than the default currency.
    image

  2. Subscription plan list shows the price with the wrong currency
    image
    Note that it shows Indian Rupee (Default company currency)

  3. When a subscription automatic sales invoice is generated, it uses the wrong currency again (default currency) instead of the currency selected in the first step.
    image

Observed result

Subscription Plan given currency is not being used in Subscription plan listing and automatically generated invoices in Subscriptions.

Expected result

Currency during listing Subscription plan and automatically generated invoices should have the selected currency in the Subscription plan.

@muhaym muhaym added the bug label Mar 2, 2021
@muhaym
Copy link
Author

muhaym commented Mar 9, 2021

@deepeshgarg007 Since you have worked on a subscription, I assume you can check this and validate whether this is actually an issue or a configuration issue.

Also, auto-generated invoices are by default in a submitted state, which blocks our ability to edit invoices before sending them to customers.

@ankush ankush added the to-validate Old issues pending validation label Dec 10, 2021
@barredterra
Copy link
Collaborator

Also, auto-generated invoices are by default in a submitted state, which blocks our ability to edit invoices before sending them to customers.

#25394

@barredterra
Copy link
Collaborator

Maybe this is related: #28916

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug to-validate Old issues pending validation
Projects
None yet
Development

No branches or pull requests

4 participants