-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multicurrency invoices using subscription #28916
fix: Multicurrency invoices using subscription #28916
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28916 +/- ##
========================================
Coverage 55.57% 55.58%
========================================
Files 1126 1126
Lines 67199 67201 +2
========================================
+ Hits 37349 37355 +6
+ Misses 29850 29846 -4
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
…-28916 fix: Multicurrency invoices using subscription (backport #28916)
@deepeshgarg007 this pr doesn't solve the issue Subscription currency #29036. I created this subscription plan by setting up ARS currency for the plan and choosing a Price List in USD. The price for this product is 300 USD for the list price selected on the plan. When issuing the invoice, takes the price as 300 ARS, which is wrong, it should be converted at the exchange rate of 1175 ARS. The correct amount should be 300 x 1175 = 352.500 ARS |
The user gets the following error on trying to create an invoice using subscription against a party having billing currency other than the company currency
Sets to test the pull request
Create a subscription plan in party currency
Create a backdated subscription as per the following details
Click on the fetch subscription updates button on the top right and see if the invoice gets generated successfully