Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accounts): Get balance for Profit and Loss accounts, only including valid transactions (not cancelled) #25580

Merged
merged 1 commit into from
May 4, 2021
Merged

fix(accounts): Get balance for Profit and Loss accounts, only including valid transactions (not cancelled) #25580

merged 1 commit into from
May 4, 2021

Conversation

ceefour
Copy link
Contributor

@ceefour ceefour commented May 4, 2021 •
edited
Loading

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

Fixes #25572

@ceefour
fix(accounts): Get balance for Profit and Loss accounts, only includi…
05f9df6 
…ng valid transactions (not cancelled)

Fixed frappe#25572 Period Closing Voucher incorrect journal entry amount for
Income/Expenses Accounts containing canceled transactions.
@deepeshgarg007 deepeshgarg007 merged commit 71c9c4f into frappe:develop May 4, 2021
@nextchamp-saqib nextchamp-saqib mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 deepeshgarg007 approved these changes

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ceefour @deepeshgarg007