Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Asset Repair #25798

Merged
merged 111 commits into from
Jul 7, 2021
Merged

Conversation

GangaManoj
Copy link
Contributor

@GangaManoj GangaManoj commented May 22, 2021

1. Asset Repair

Changes
  • Update Asset status to Out of Order when the asset is being repaired and change it back once its done.

Screenshot 2021-05-22 at 7 27 37 AM

  • Replace Item Name and Item Code with Asset Name.

Screenshot 2021-05-22 at 7 43 25 AM

  • Add Stock Consumption Details section to record the details of all stock items consumed during repair. Their total value will be added to the asset's value.

Screenshot 2021-05-22 at 7 55 27 AM

  • Decrease stock quantity for the items consumed during asset repair in the specified warehouse.

  • Add Total Repair Cost field. It contains the sum of Repair Cost and the total value of all stock items consumed during the repair.

  • Add Stock Consumed During Repair checkbox. If checked, it will display the Stock Consumption Details section and the Total Repair Cost field.

  • Add Purchase Invoice field so the user can record purchase of the repair service as well as the additional items necessary for repairing the asset.

Screenshot 2021-05-22 at 8 24 17 AM

  • Add Capitalize Repair Cost checkbox. If checked, the Repair Cost will be added to the asset's value.

Screenshot 2021-05-22 at 7 49 03 AM

  • Create GL entries to capitalise repair cost.

  • Add View General Ledger button.

Screenshot 2021-05-22 at 8 15 05 AM

  • Add Accounting Dimensions section.

Screenshot 2021-05-22 at 8 15 49 AM

  • Remove Assign To.

  • Add Asset Depreciation Details section with Increase In Asset Life field.

Screenshot 2021-05-22 at 8 26 14 AM

  • Modify Depreciation Schedule according to Increase In Asset Life and increase in Asset Value.

Screenshot 2021-05-22 at 8 27 44 AM

2. Asset

Changes
  • Group all existing buttons under Manage and add Repair Asset button.

Screenshot 2021-05-22 at 7 29 33 AM

  • Add Asset Value field.

Screenshot 2021-05-22 at 7 34 48 AM

  • Fix Depreciation Amount calculation.

Screenshot 2021-05-22 at 7 39 30 AM

3. Company

Changes - Rename _Fixed Asset Depreciation Settings_ section to _Fixed Asset Defaults_. - Add _Repair and Maintenance Account_.

Screenshot 2021-05-22 at 8 34 25 AM

Docs: frappe/erpnext_documentation#357

@nextchamp-saqib nextchamp-saqib changed the title Asset Repair Refactor refactor: Asset Repair May 25, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 42.866% when pulling 550fe8a on GangaManoj:asset-repair-refactor into 943b46a on frappe:develop.

Copy link
Member

@nextchamp-saqib nextchamp-saqib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More changes. 😅

erpnext/assets/doctype/asset/asset.py Outdated Show resolved Hide resolved
erpnext/assets/doctype/asset/asset.py Outdated Show resolved Hide resolved
erpnext/assets/doctype/asset/asset.py Show resolved Hide resolved
erpnext/assets/doctype/asset_repair/asset_repair.js Outdated Show resolved Hide resolved
erpnext/assets/doctype/asset_repair/asset_repair.json Outdated Show resolved Hide resolved
erpnext/assets/doctype/asset_repair/test_asset_repair.py Outdated Show resolved Hide resolved
@nextchamp-saqib nextchamp-saqib merged commit 0b320b5 into frappe:develop Jul 7, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants