Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Patch tests #25946

Merged
merged 8 commits into from
Jun 10, 2021
Merged

ci: Update Patch tests #25946

merged 8 commits into from
Jun 10, 2021

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Jun 3, 2021 •
edited
Loading

Changes

  • Dropped patches prior to v10
    • Restored v7 backup to newly created bench on v10.x.x branch.
    • Ran migrations.
    • Uploaded backup to erpnext.com
    • Deleted patches that have already been run from backup's patch log
  • Use v10 ERPNext site backup to run patch migrations (Updated existing v7 backup to v10)
  • Fixed patches' errors

@gavindsouza
Copy link
Collaborator Author

Similar Frappe PR: frappe/frappe#13417

@gavindsouza gavindsouza changed the title ci: Patch tests ci: Update Patch tests Jun 3, 2021
@gavindsouza
chore: Drop old patches
5bf5775 
v7 backup was restored and upgraded to latest v10.x.x branch. The
patches run uptil the upgrade are removed in this change. This means
only existing v10 sites are allowed direct upgrade to v13 and newer
@gavindsouza
chore: Drop < v10 patches from list
8697e89 
v7 backup was restored and upgraded to latest v10.x.x branch. The patches run uptil the upgrade are removed in this change. This means only existing v10 sites are allowed direct upgrade to v13 and newer

There are older version patches still left since they're being used in later ERPNext versions too.
@gavindsouza
ci: Update ERPNext backup patch test >= v10
c68006b 
* Generated v10 backup archive
    * used old v7 erpnext backup hosted via build.erpnext.com
    * upgraded to v10 frappe + erpnext
* Hosted backup on https://erpnext.com/files/v10-erpnext.sql.gz
@gavindsouza gavindsouza marked this pull request as ready for review June 4, 2021 14:53
@gavindsouza
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2021

Command backport version-13-hotfix: pending

Waiting for the pull request to get merged

@rohitwaghchaure rohitwaghchaure merged commit 64cc60f into frappe:develop Jun 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2021

Command backport version-13-hotfix: failure

No backport have been created
GitHub App like Mergify are not allowed to create pull request where .github/workflows is changed.

@rohitwaghchaure
Copy link
Collaborator

@gavindsouza Backport not working for erpnext app, open new PR on version-13-hotfix branch

@gavindsouza gavindsouza mentioned this pull request Jun 10, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@rohitwaghchaure
Merge pull request frappe#25946 from gavindsouza/patch-tests
e79715c 
ci: Update Patch tests
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure approved these changes

@nabinhait nabinhait Awaiting requested review from nabinhait

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavindsouza @rohitwaghchaure