Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: lead #26085

Merged
merged 16 commits into from
Aug 10, 2021
Merged

refactor: lead #26085

merged 16 commits into from
Aug 10, 2021

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Jun 16, 2021 •
edited
Loading

  • Updated Lead List View and Filters
  • Form Cleanup. Ref Backlog ([CRM] Lead Refactor)
  • Removed code for auto-creation of Address and Contact.
  • Removing links(Address, Contact, Call Log) on the deletion of Lead.
  • some lead.py file refactor.
  • Added Contact Date from the header section.
    image

@anupamvs anupamvs added the WIP label Jun 16, 2021
@ruchamahabal ruchamahabal marked this pull request as draft July 8, 2021 07:31
@stale
Copy link

stale bot commented Jul 23, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 23, 2021
@stale stale bot closed this Jul 26, 2021
@ruchamahabal
Copy link
Member

@anupamvs Complete this and re-open

@anupamvs anupamvs reopened this Jul 27, 2021
@stale stale bot removed the inactive label Jul 27, 2021
@anupamvs anupamvs removed the WIP label Jul 28, 2021
@ruchamahabal ruchamahabal marked this pull request as ready for review July 29, 2021 07:22
ruchamahabal
ruchamahabal previously requested changes Jul 29, 2021
View reviewed changes
erpnext/crm/doctype/lead/lead.json Outdated Show resolved Hide resolved
erpnext/crm/doctype/lead/lead.json Outdated Show resolved Hide resolved
erpnext/crm/doctype/lead/lead.json Show resolved Hide resolved
erpnext/crm/doctype/lead/lead.json Show resolved Hide resolved
erpnext/crm/doctype/lead/lead.js Outdated Show resolved Hide resolved
erpnext/crm/doctype/lead/lead.py Show resolved Hide resolved
erpnext/crm/doctype/lead/lead.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 9, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 42.781% when pulling 2f06c3e on anupamvs:lead-cleanup into 7ba8c82 on frappe:develop.

@anupamvs anupamvs dismissed ruchamahabal’s stale review August 9, 2021 10:36

Done the requested changes.

@anupamvs anupamvs merged commit e196dee into frappe:develop Aug 10, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@anupamvs
Merge pull request frappe#26085 from anupamvs/lead-cleanup
cb3c5e0 
refactor: lead
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pateljannat pateljannat Awaiting requested review from pateljannat

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal

Assignees

@ruchamahabal ruchamahabal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anupamvs @ruchamahabal @coveralls