Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace usage of render with get_response #26088

Merged
merged 8 commits into from
Jun 17, 2021
Merged

refactor: Replace usage of render with get_response #26088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c6d3e0
test: Replace usage of render with get_response
surajshetty3416 May 19, 2021
2f8a742
refactor: Replace render imports
surajshetty3416 May 25, 2021
b14a935
Merge branch 'develop' of github.com:frappe/erpnext into refactor-web…
surajshetty3416 May 25, 2021
d3b9edd
fix: Remove unnecessary import
surajshetty3416 May 25, 2021
df680a2
Merge branch 'develop' of github.com:frappe/erpnext into refactor-web…
surajshetty3416 May 27, 2021
d1902df
Merge branch 'develop' of github.com:frappe/erpnext into refactor-web…
surajshetty3416 Jun 14, 2021
00332d1
Merge branch 'develop' of github.com:frappe/erpnext into refactor-web…
surajshetty3416 Jun 17, 2021
e8e4841
ci: Build frappe assets
surajshetty3416 Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/helper/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ sed -i 's/redis_socketio:/# redis_socketio:/g' Procfile
bench get-app erpnext "${GITHUB_WORKSPACE}"
bench start &
bench --site test_site reinstall --yes
bench build --app frappe
4 changes: 2 additions & 2 deletions erpnext/portal/doctype/homepage/test_homepage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
import frappe
import unittest
from frappe.utils import set_request
from frappe.website.render import render
from frappe.website.serve import get_response

class TestHomepage(unittest.TestCase):
def test_homepage_load(self):
set_request(method='GET', path='home')
response = render()
response = get_response()

self.assertEqual(response.status_code, 200)

Expand Down
6 changes: 3 additions & 3 deletions erpnext/portal/doctype/homepage_section/test_homepage_section.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import unittest
from bs4 import BeautifulSoup
from frappe.utils import set_request
from frappe.website.render import render
from frappe.website.serve import get_response

class TestHomepageSection(unittest.TestCase):
def test_homepage_section_card(self):
Expand All @@ -26,7 +26,7 @@ def test_homepage_section_card(self):
pass

set_request(method='GET', path='home')
response = render()
response = get_response()

self.assertEqual(response.status_code, 200)

Expand Down Expand Up @@ -59,7 +59,7 @@ def test_homepage_section_custom_html(self):
}).insert()

set_request(method='GET', path='home')
response = render()
response = get_response()

self.assertEqual(response.status_code, 200)

Expand Down
4 changes: 1 addition & 3 deletions erpnext/portal/product_configurator/test_product_configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@

from bs4 import BeautifulSoup
import frappe, unittest
from frappe.utils import set_request, get_html_for_route
from frappe.website.render import render
from frappe.utils import get_html_for_route
from erpnext.portal.product_configurator.utils import get_products_for_website
from erpnext.stock.doctype.item.test_item import make_item_variant

test_dependencies = ["Item"]

Expand Down
2 changes: 1 addition & 1 deletion erpnext/setup/doctype/item_group/item_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from frappe.utils import nowdate, cint, cstr
from frappe.utils.nestedset import NestedSet
from frappe.website.website_generator import WebsiteGenerator
from frappe.website.render import clear_cache
from frappe.website.utils import clear_cache
from frappe.website.doctype.website_slideshow.website_slideshow import get_slideshow
from erpnext.shopping_cart.product_info import set_product_info_for_website
from erpnext.utilities.product import get_qty_in_stock
Expand Down
2 changes: 1 addition & 1 deletion erpnext/stock/doctype/item/item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from frappe.website.doctype.website_slideshow.website_slideshow import \
get_slideshow

from frappe.website.render import clear_cache
from frappe.website.utils import clear_cache
from frappe.website.website_generator import WebsiteGenerator


Expand Down
1 change: 0 additions & 1 deletion erpnext/templates/pages/partners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

from __future__ import unicode_literals
import frappe
import frappe.website.render

page_title = "Partners"

Expand Down