Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add provision for process loss in manufac #26151

Merged
merged 25 commits into from
Aug 26, 2021

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Jun 22, 2021

Description

BOM Functionality

Screen Shot 2021-06-25 at 14 36 38

  • Scrap table item has Is Process Loss checkbox, this sets the item as a Loss Item.
  • Is Process Loss is set when Scrap Item == Finished Item.
  • Process Loss is different from Scrap in the sense that it is lost and has no value (scrap may have value) so the rate will be set to 0.
  • Dialog allows setting process loss as a percentage of finished item quantity.

Stock Entry (Manufacture):

Screen Shot 2021-06-25 at 14 37 34

  • On setting items using WO or BOM, Is Process Loss value carries over.
  • This implies a 0 rate (unless changed), and a different completion calculation.
  • Process Loss calculation: Finished Item Quantity = BOM Quantity - PL Item Quantity

Process Loss Report

image

  • Shows aggregated process loss value and quantity across stock entries, grouped by Work Order.
  • Process Loss Value = Process Loss Qty * sum(Total Incoming Value) / sum(Actual Produced Qty)

Documentation PR: frappe/erpnext_documentation#356

@18alantom 18alantom marked this pull request as ready for review June 25, 2021 09:46
@stale
Copy link

stale bot commented Jul 20, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 20, 2021
@ameerbab
Copy link

@18alantom
Any updates about the beta release ?

@stale stale bot removed the inactive label Jul 20, 2021
@18alantom 18alantom requested a review from ankush as a code owner July 21, 2021 11:43
@18alantom
Copy link
Member Author

@18alantom
Any updates about the beta release ?

@ameerbab still waiting on review, once done should be merged and out by the end of this month.

@marination marination self-assigned this Aug 5, 2021
@marination
Copy link
Collaborator

@18alantom add a test for process loss impact on Manufacture Entry (Stock Entry) and Work order too. So BOM (with process loss) -> WO -> Manufacture Entry -> Check impact on WO if it is marked as completed

@18alantom 18alantom marked this pull request as draft August 10, 2021 07:25
@marination marination added the CI-failing Unit tests or patch tests are failing. label Aug 25, 2021
marination added a commit that referenced this pull request Aug 26, 2021
feat: add provision for process loss in manufac (frontport #26151)
@marination marination removed the CI-failing Unit tests or patch tests are failing. label Aug 26, 2021
@marination
Copy link
Collaborator

Unrelated closing voucher and appointment tests failing

@marination marination merged commit 6e136c4 into frappe:version-13-hotfix Aug 26, 2021
@ameerbab
Copy link

Dear @18alantom,

I appreciate your effort and thanks for your contribution.

@18alantom
Copy link
Member Author

@ameerbab you're welcome, much appreciated! :)

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
feat: add provision for process loss in manufac (frontport frappe#26151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants