feat(CRM): Sales Pipeline Analytics Report and Opportunity Summary by Sales Stage Report #26639

mohammedyusufshaikh · 2021-07-26T10:51:59Z

Sales Pipeline Analytics

The following report will provide a count of opportunities or amounts that will be earned by the opportunities on a monthly or quarterly basis and also provides filters to funnel the data. This report is a forecast based on the Expected Closing Date and Opportunity Amount / Count.

Source of Truth: Opportunity doctype
Columns: Based on Frequency (Monthly -> Months, Quarterly -> Quarters)
Filters:

Pipeline By
Owner (Assigned To)
Sales Stage (master)
From and To Date
Company
Assigned To
Status (Multiselect): exclude Lost/Closed in selection
Data based on: (cell values will either be Number/Amount)
- Number: Number of opportunities who have Expected Closing Date falling in that quarter/month.
- Amount: The total opportunity amount at that stage. (fetch from Opportunity Amount field).
Opportunity Source/Type

Opportunity Summary by Sales Stage

A report to show a summary of opportunities by Sales Stages.

Source of Truth: Opportunity doctype
Columns: Sales Stages (master)
Filters:

Company
Based On
Opportunity Owner (Assigned To)
Opportunity Source (master)
Opportunity Type (master)
From Date and To Date (opportunity creation date)
Data based on: (cell values will either be Number/Amount)
- Number: Number of opportunities at that stage.
- Amount: The total opportunity amount at that stage. (fetched from Opportunity Amount field).
Status (Multiselect): Open, Quotation, Converted, Replied
Opportunity Source
Opportunity Type

no-docs (Docs will be added once versioning for v14 is done in the wiki documentation app)

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py

anupamvs · 2021-08-04T06:39:38Z

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py

+
+		if self.filters.get("data_based_on") == "Number":
+			for data in self.query_result:
+				for count in range(0,8):


for i, value in enumerate(values):

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.js

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py

erpnext/crm/report/sales_pipeline_analytics/sales_pipeline_analytics.py

stale · 2021-08-19T09:12:27Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

ruchamahabal · 2021-08-19T09:14:42Z

Keep Alive

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py

coveralls · 2021-08-27T15:32:45Z

Coverage increased (+0.1%) to 51.646% when pulling 6a1ae7e on mohammedyusufshaikh:sales_report into 88c9fe3 on frappe:develop.

- smaller functions - variable and function naming

… Sales Stage Report (frappe#26639) * feat: Sales Pipeline Analytics Report * fix: sider Issues and added tests * fix: Semgrep Issue * feat: Opportunity Summary by Sales Stage Report * fix: add some checks and tests * fix: sider issues and test * fix: additional checks for error handling and minor changes * fix: remove unused conditions * fix: Changes mentioned on PR * fix: currency conversions and other changes * fix: remove unused imports * fix: correction for failing test case * fix: recorrected failing test case * fix: sider issues and resolve test case errors * fix: rewrite query using query builder * fix: test case changes * fix: sider fixes and other changes * fix: clear data before running test * fix: test case fixed * refactor: code formatting - smaller functions - variable and function naming * refactor: improve code formatting * fix: linter issues * fix: linter issues * fix: change indentation to tabs * fix: linter issues * fix: naming, code formatting * fix: quarterly values not showing up in Sales Pipeline Analytics * fix: typo in tests Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>

ankush · 2022-01-24T09:16:17Z

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py

+
+			self.convert_to_base_currency()
+
+			dataframe = pandas.DataFrame.from_records(self.query_result)


@mohammedyusufshaikh @ruchamahabal lets stop using this module.

It's a crutch to use pandas (millions of lines of dependency) for something that can be done in 5-10 line for loop 😅

mohammedyusufshaikh added 7 commits July 26, 2021 15:58

feat: Sales Pipeline Analytics Report

14b2c5f

fix: sider Issues and added tests

4998658

fix: Semgrep Issue

6521acd

feat: Opportunity Summary by Sales Stage Report

3c22097

fix: add some checks and tests

6748dfc

fix: sider issues and test

8d948a2

fix: additional checks for error handling and minor changes

b9053f8

ruchamahabal changed the title ~~feat: Sales Pipeline Analytics Report~~ feat(CRM): Sales Pipeline Analytics Report and Opportunity Summary by Sales Stage Report Aug 4, 2021

anupamvs reviewed Aug 4, 2021

View reviewed changes

anupamvs added the fix-sider-issues Check and fix issues listed by Sider label Aug 4, 2021

fix: remove unused conditions

ea8324d

ruchamahabal requested changes Aug 4, 2021

View reviewed changes

ruchamahabal marked this pull request as ready for review August 4, 2021 08:13

ruchamahabal requested a review from pateljannat as a code owner August 4, 2021 08:13

fix: Changes mentioned on PR

c47c6ff

stale bot added the inactive label Aug 19, 2021

stale bot removed the inactive label Aug 19, 2021

mohammedyusufshaikh added 2 commits August 19, 2021 20:06

fix: currency conversions and other changes

2edf3d8

fix: remove unused imports

d31b164

anupamvs reviewed Aug 23, 2021

View reviewed changes

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py Outdated Show resolved Hide resolved

erpnext/crm/report/opportunity_summary_by_sales_stage/opportunity_summary_by_sales_stage.py Outdated Show resolved Hide resolved

anupamvs added the CI-failing Unit tests or patch tests are failing. label Aug 23, 2021

mohammedyusufshaikh force-pushed the sales_report branch from 32f365f to d31b164 Compare August 23, 2021 12:24

mohammedyusufshaikh added 2 commits August 23, 2021 18:03

fix: correction for failing test case

8ab5f33

fix: recorrected failing test case

171640e

mohammedyusufshaikh force-pushed the sales_report branch from c91a5a4 to 171640e Compare August 24, 2021 11:02

fix: sider issues and resolve test case errors

7f5ff69

mohammedyusufshaikh force-pushed the sales_report branch from b5b0e09 to 7f5ff69 Compare August 24, 2021 12:38

ruchamahabal self-assigned this Aug 25, 2021

mohammedyusufshaikh force-pushed the sales_report branch from 5563799 to 3042302 Compare August 26, 2021 12:57

fix: clear data before running test

d31c778

mohammedyusufshaikh force-pushed the sales_report branch from 9a92f30 to d31c778 Compare August 27, 2021 07:38

fix: test case fixed

0f25145

mohammedyusufshaikh force-pushed the sales_report branch from 3e6e4b1 to 0f25145 Compare August 27, 2021 14:42

Merge branch 'develop' into sales_report

6ecc2bf

ruchamahabal added 2 commits August 31, 2021 18:20

refactor: code formatting

0017bc5

- smaller functions - variable and function naming

Merge branch 'develop' into sales_report

741cbf0

ruchamahabal removed CI-failing Unit tests or patch tests are failing. fix-sider-issues Check and fix issues listed by Sider labels Aug 31, 2021

mohammedyusufshaikh and others added 7 commits September 1, 2021 12:34

refactor: improve code formatting

67beec8

Merge branch 'develop' into sales_report

ce82701

fix: linter issues

86429a4

fix: linter issues

cfe06ff

fix: change indentation to tabs

8234f7d

Merge branch 'develop' into sales_report

3ce6523

fix: linter issues

19dff71

ruchamahabal force-pushed the sales_report branch from 12f87e9 to 19dff71 Compare September 6, 2021 16:01

ruchamahabal added 2 commits September 6, 2021 22:15

fix: naming, code formatting

efe425e

fix: quarterly values not showing up in Sales Pipeline Analytics

057b28f

ruchamahabal force-pushed the sales_report branch from 898cf19 to 057b28f Compare September 7, 2021 04:34

Merge branch 'develop' into sales_report

440d504

ruchamahabal previously approved these changes Sep 7, 2021

View reviewed changes

fix: typo in tests

6a1ae7e

ruchamahabal dismissed their stale review via 6a1ae7e September 7, 2021 05:00

ruchamahabal merged commit d795e55 into frappe:develop Sep 7, 2021

ankush reviewed Jan 24, 2022

View reviewed changes

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(CRM): Sales Pipeline Analytics Report and Opportunity Summary by Sales Stage Report #26639

feat(CRM): Sales Pipeline Analytics Report and Opportunity Summary by Sales Stage Report #26639

mohammedyusufshaikh commented Jul 26, 2021 •

edited by ruchamahabal

Loading

anupamvs Aug 4, 2021

stale bot commented Aug 19, 2021

ruchamahabal commented Aug 19, 2021

coveralls commented Aug 27, 2021 •

edited

Loading

ankush Jan 24, 2022


		self.convert_to_base_currency()

		dataframe = pandas.DataFrame.from_records(self.query_result)

feat(CRM): Sales Pipeline Analytics Report and Opportunity Summary by Sales Stage Report #26639

feat(CRM): Sales Pipeline Analytics Report and Opportunity Summary by Sales Stage Report #26639

Conversation

mohammedyusufshaikh commented Jul 26, 2021 • edited by ruchamahabal Loading

Sales Pipeline Analytics

Opportunity Summary by Sales Stage

anupamvs Aug 4, 2021

Choose a reason for hiding this comment

stale bot commented Aug 19, 2021

ruchamahabal commented Aug 19, 2021

coveralls commented Aug 27, 2021 • edited Loading

ankush Jan 24, 2022

Choose a reason for hiding this comment

mohammedyusufshaikh commented Jul 26, 2021 •

edited by ruchamahabal

Loading

coveralls commented Aug 27, 2021 •

edited

Loading