-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: common party accounting #27039
Merged
deepeshgarg007
merged 13 commits into
frappe:develop
from
nextchamp-saqib:common-party-acc
Aug 26, 2021
Merged
feat: common party accounting #27039
deepeshgarg007
merged 13 commits into
frappe:develop
from
nextchamp-saqib:common-party-acc
Aug 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextchamp-saqib
requested review from
deepeshgarg007,
marination and
rohitwaghchaure
as code owners
August 19, 2021 12:37
nextchamp-saqib
force-pushed
the
common-party-acc
branch
from
August 19, 2021 12:40
4499e56
to
8e79c48
Compare
My pleasure @nextchamp-saqib |
deepeshgarg007
requested changes
Aug 25, 2021
nextchamp-saqib
added
backport version-13-hotfix
and removed
backport version-13-hotfix
labels
Aug 25, 2021
deepeshgarg007
approved these changes
Aug 26, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
feat: common party accounting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR incorporates the solution of this app for handling scenarios where sales invoices/purchase invoices are to be made against suppliers/customers
The solution proposed by the app is to:
A new doctype Party Link is introduced to link a customer with a supplier.
A new toggle is added to accounts settings to enable/disable the automatic creation of the journal entry.
Thanks @ahmadpak for the solution!
Docs: https://docs.erpnext.com/docs/v13/user/manual/en/accounts/articles/common_party_accounting