Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Accounts, Selling & Assets Onboarding cleanup #27112

Merged
merged 34 commits into from
Aug 27, 2021
Merged

feat: Accounts, Selling & Assets Onboarding cleanup #27112

merged 34 commits into from
Aug 27, 2021

Conversation

kamaljohnson
Copy link
Contributor

@kamaljohnson kamaljohnson commented Aug 24, 2021 •
edited by nabinhait
Loading

feat(onboarding-cleanup): Add onboarding steps for Accounting, Assets and Selling modules

Accounting

  • Review Company ( show 'Company List' )

image

  • Review Chart of Accounts ( show 'Chart of Accounts' )

image

  • Setting up Taxes ( form tour for 'Sales Taxes and Charges Template' )

image

  • Account Settings ( form tour for 'Account Settings' )

image

  • Cost Centers for Budgeting and Analysis ( show 'Cost Center Tree' )

image

  • Create your first Purchase Invoice ( form tour for 'Purchase Invoice' )

image

  • Updating Opening Balances ( video tutorial )

image

  • Financial Statements ( show general report )

image

Assets

  • Review Fixed Asset Accounts ( show 'Chart of Accounts' )

image

  • Define Asset Category ( form tour for 'Asset Category' )

image

  • Create Asset Item ( form tour for 'Item' )

image

  • Purchase an Asset ( form tour for 'Purchase Receipt' )

image

  • Add an Existing Asset ( form tour for 'Asset' )

image

Selling

  • Selling Settings ( form tour for 'Selling Settings' )

image

  • Sales Order ( form tour for 'Sales Order' )

image

no-docs

nextchamp-saqib and others added 29 commits June 29, 2021 15:01
@nextchamp-saqib
refactor: company form fields arrangement
9b6c8f3
@nextchamp-saqib
refactor: accounts onboarding steps
7bfdaee
@nextchamp-saqib
Merge branch 'develop' of https://github.com/frappe/erpnext into onbo…
ecb4ab0 
…arding-cleanup
@nextchamp-saqib
refactor: re-arrange fields & modify labels in company form
efec69e
@nextchamp-saqib
feat: onbording steps for accounts module
ccc401d
@Anuja-pawar @nextchamp-saqib
fix: updated onboarding steps for selling module
1ad6d39
@nextchamp-saqib
fix: remove unwanted steps from accounts
06a7b1a
@nextchamp-saqib
feat: add more onboarding steps
df815e9
@AfshanKhan
Merge branch 'develop' into onboarding-cleanup
90605fc
@AfshanKhan
Merge branch 'develop' into onboarding-cleanup
4c84bac
@kamaljohnson
Merge branch 'onboarding-cleanup' of https://github.com/nextchamp-saq…
0a2d8b8 
…ib/erpnext into onboarding_clearnup
@kamaljohnson
Merge branch 'frappe:develop' into onboarding_cleanup
7ff74b7
@kamaljohnson
feat: Refactor onboarding-module for accounting workspace
3b0cb29
@kamaljohnson
feat: Add basic asset onboarding steps
447fd4e
@kamaljohnson
feat: Add basic asset item form tour
c1ac933
@kamaljohnson
feat: Add basic selling onboarding-steps
c3cd1c7
@kamaljohnson
feat: Add basic form tour for purchase recipt
81924f9
@kamaljohnson
feat: Add basic form tour for existing asset
19da220
@kamaljohnson
Merge branch 'frappe:develop' into onboarding_cleanup
621e316
@kamaljohnson
feat: Adding asset category form tour
0a1d67d
@kamaljohnson
feat: Add form tour for asset category
4cb3f77
@kamaljohnson
feat: Refactor sales taxes and charges template form tour with new me…
9643db9 
…thod
@kamaljohnson
refactor: Remove old form tour for accounts settings
281d197
@kamaljohnson
refactor: Change asset category form tour with new tour method
3df250e
@kamaljohnson
refactor: Change asset item form tour with new tour method
3b94307
@kamaljohnson
refactor: Change purchase receipt form tour with new tour method
4563098
@kamaljohnson
refactor: Change asset form tour with new tour method
9b0afb9
@kamaljohnson
refactor: Remove old form tour for selling settings
9914fd5
@kamaljohnson
refactor: general fix/typo in onboarding steps
8885390
nabinhait
nabinhait requested changes Aug 25, 2021
View reviewed changes
erpnext/accounts/form_tour/purchase_invoice/purchase_invoice.json Outdated Show resolved Hide resolved
erpnext/accounts/form_tour/purchase_invoice/purchase_invoice.json Outdated Show resolved Hide resolved
...xt/accounts/form_tour/sales_taxes_and_charges_template/sales_taxes_and_charges_template.json Outdated Show resolved Hide resolved
erpnext/accounts/onboarding_step/financial_statements/financial_statements.json Outdated Show resolved Hide resolved
erpnext/assets/form_tour/asset_category/asset_category.json Outdated Show resolved Hide resolved
erpnext/assets/onboarding_step/existing_asset/existing_asset.json Outdated Show resolved Hide resolved
erpnext/assets/onboarding_step/existing_asset/existing_asset.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/sales_order/sales_order.js Outdated Show resolved Hide resolved
erpnext/stock/form_tour/item/item.json Outdated Show resolved Hide resolved
erpnext/stock/form_tour/item/item.json Outdated Show resolved Hide resolved
@nabinhait nabinhait self-assigned this Aug 25, 2021
@anupamvs anupamvs added the fix-sider-issues Check and fix issues listed by Sider label Aug 25, 2021
@nextchamp-saqib nextchamp-saqib changed the title Onboarding cleanup feat: Accounts, Selling & Assets Onboarding cleanup Aug 26, 2021
@nabinhait
Copy link
Member

@kamaljohnson Errors while installing fixtures

@kamaljohnson
Copy link
Contributor Author

@kamaljohnson Errors while installing fixtures

@nabinhait the local site is running fine for me, Can you please show the error.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.598% when pulling bdaf335 on kamaljohnson:onboarding_cleanup into c8f22e5 on frappe:develop.

@nabinhait nabinhait merged commit a285b5b into frappe:develop Aug 27, 2021
@kamaljohnson kamaljohnson deleted the onboarding_cleanup branch September 7, 2021 11:18
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@kamaljohnson @nextchamp-saqib
@Anuja-pawar @AfshanKhan @nabinhait
feat: Accounts, Selling & Assets Onboarding cleanup (frappe#27112)
eb67b00 
* refactor: company form fields arrangement

* refactor: accounts onboarding steps

* refactor: re-arrange fields & modify labels in company form

* feat: onbording steps for accounts module

* fix: updated onboarding steps for selling module

* fix: remove unwanted steps from accounts

* feat: add more onboarding steps

* feat: Refactor onboarding-module for accounting workspace

* feat: Add basic asset onboarding steps

* feat: Add basic asset item form tour

* feat: Add basic selling onboarding-steps

* feat: Add basic form tour for purchase recipt

* feat: Add basic form tour for existing asset

* feat: Adding asset category form tour

* feat: Add form tour for asset category

* feat: Refactor sales taxes and charges template form tour with new  method

* refactor: Remove old form tour for accounts settings

* refactor: Change asset category form tour with new tour method

* refactor: Change asset item form tour with new tour method

* refactor: Change purchase receipt form tour with new tour method

* refactor: Change asset form tour with new tour method

* refactor: Remove old form tour for selling settings

* refactor: general fix/typo in onboarding steps

* Apply suggestions from code review

Co-authored-by: Nabin Hait <nabinhait@gmail.com>

* refactor: Remove old form tour method for sales order.

* fix: removed duplicate section break

* fix: Removed duplicate fields

Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Anuja <anuja.pawar20@gmail.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
@nextchamp-saqib
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify mergify bot mentioned this pull request Nov 22, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
@kamaljohnson
feat: Accounts, Selling & Assets Onboarding cleanup (#27112)
144e108 
* refactor: company form fields arrangement

* refactor: accounts onboarding steps

* refactor: re-arrange fields & modify labels in company form

* feat: onbording steps for accounts module

* fix: updated onboarding steps for selling module

* fix: remove unwanted steps from accounts

* feat: add more onboarding steps

* feat: Refactor onboarding-module for accounting workspace

* feat: Add basic asset onboarding steps

* feat: Add basic asset item form tour

* feat: Add basic selling onboarding-steps

* feat: Add basic form tour for purchase recipt

* feat: Add basic form tour for existing asset

* feat: Adding asset category form tour

* feat: Add form tour for asset category

* feat: Refactor sales taxes and charges template form tour with new  method

* refactor: Remove old form tour for accounts settings

* refactor: Change asset category form tour with new tour method

* refactor: Change asset item form tour with new tour method

* refactor: Change purchase receipt form tour with new tour method

* refactor: Change asset form tour with new tour method

* refactor: Remove old form tour for selling settings

* refactor: general fix/typo in onboarding steps

* Apply suggestions from code review

Co-authored-by: Nabin Hait <nabinhait@gmail.com>

* refactor: Remove old form tour method for sales order.

* fix: removed duplicate section break

* fix: Removed duplicate fields

Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Anuja <anuja.pawar20@gmail.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
(cherry picked from commit a285b5b)

# Conflicts:
#	erpnext/setup/doctype/company/company.json
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-hotfix

✅ Backports have been created

@nextchamp-saqib
Copy link
Member

@Mergifyio backport version-13-pre-release

@mergify mergify bot mentioned this pull request Nov 22, 2021
Closed
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
@kamaljohnson
feat: Accounts, Selling & Assets Onboarding cleanup (#27112)
758e45e 
* refactor: company form fields arrangement

* refactor: accounts onboarding steps

* refactor: re-arrange fields & modify labels in company form

* feat: onbording steps for accounts module

* fix: updated onboarding steps for selling module

* fix: remove unwanted steps from accounts

* feat: add more onboarding steps

* feat: Refactor onboarding-module for accounting workspace

* feat: Add basic asset onboarding steps

* feat: Add basic asset item form tour

* feat: Add basic selling onboarding-steps

* feat: Add basic form tour for purchase recipt

* feat: Add basic form tour for existing asset

* feat: Adding asset category form tour

* feat: Add form tour for asset category

* feat: Refactor sales taxes and charges template form tour with new  method

* refactor: Remove old form tour for accounts settings

* refactor: Change asset category form tour with new tour method

* refactor: Change asset item form tour with new tour method

* refactor: Change purchase receipt form tour with new tour method

* refactor: Change asset form tour with new tour method

* refactor: Remove old form tour for selling settings

* refactor: general fix/typo in onboarding steps

* Apply suggestions from code review

Co-authored-by: Nabin Hait <nabinhait@gmail.com>

* refactor: Remove old form tour method for sales order.

* fix: removed duplicate section break

* fix: Removed duplicate fields

Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Anuja <anuja.pawar20@gmail.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
(cherry picked from commit a285b5b)

# Conflicts:
#	erpnext/setup/doctype/company/company.json
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-pre-release

✅ Backports have been created

@GangaManoj GangaManoj mentioned this pull request Dec 1, 2021
Closed
@rohitwaghchaure rohitwaghchaure mentioned this pull request Dec 5, 2021
Merged
@ankush ankush mentioned this pull request Jun 20, 2022
Closed
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush Awaiting requested review from ankush

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@marination marination Awaiting requested review from marination

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@nabinhait nabinhait Awaiting requested review from nabinhait

Assignees

@nabinhait nabinhait

Labels
fix-sider-issues Check and fix issues listed by Sider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kamaljohnson @nabinhait @coveralls @nextchamp-saqib @anupamvs @Anuja-pawar @AfshanKhan