Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Taxjar Integration update #27143

Merged
merged 9 commits into from
Aug 31, 2021

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Aug 25, 2021

TaxJar is a platform that provides automated sales tax compliance, the api integration helps in auto-calculating sales tax in sales invoices. Primarily this integration is being developed to accommodate and ease taxation for the United States region.
ERPNext had the basic api integration setup, this update is to polish it further and make it fit for certification.
The tax rates are based on the states and products(product tax category).

Updates:

  1. Tax calculation for line items(every row of the items table)
  2. Address validation and retrieving state codes (api requires 2 letter state codes ex New York - NY)
  3. Product Tax Category Doctype for different tax categories
  4. Product tax category field in Item master and Sales Item table, Tax Collectable, Taxable Amount fields in Sales Item Table that stores the said values from api response
  5. Correct posting of Return invoices
  6. API calls having the x-api-version and plugin parameters
  7. Corrected shipping address assignment order
  • TaxJar Settings page in ERPNext

  • Product Tax Category field in Item Master
    Screenshot 2021-08-25 at 6 35 23 PM

  • Sales Taxes and charges table auto populating with the rates
    Screenshot 2021-08-25 at 6 36 13 PM

  • Taxable Amount and Tax Collectible retrieved form the response and stored

  • Transactions and breakdown on the TaxJar account transactions dashboard
    Screenshot 2021-08-25 at 6 40 40 PM

docs: https://docs.erpnext.com/docs/v13/user/manual/en/erpnext_integration/new?wiki_page_patch=4eb79f3bef

@deepeshgarg007 deepeshgarg007 self-assigned this Aug 25, 2021
@deepeshgarg007 deepeshgarg007 added the fix-sider-issues Check and fix issues listed by Sider label Aug 27, 2021
@coveralls
Copy link

coveralls commented Aug 30, 2021

Coverage Status

Coverage remained the same at 51.627% when pulling 531f1b3 on nemesis189:taxjar-integration-update into 6067537 on frappe:develop.

erpnext/erpnext_integrations/taxjar_integration.py Outdated Show resolved Hide resolved
erpnext/regional/united_states/setup.py Outdated Show resolved Hide resolved
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review August 31, 2021 05:18
@deepeshgarg007 deepeshgarg007 requested review from deepeshgarg007 and removed request for nextchamp-saqib August 31, 2021 05:18
@deepeshgarg007 deepeshgarg007 removed the fix-sider-issues Check and fix issues listed by Sider label Aug 31, 2021
@deepeshgarg007 deepeshgarg007 merged commit 7004944 into frappe:develop Aug 31, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 31, 2021
* feat: Taxjar Integration update

* added taxable_amount,taxable_amount fields in setup.py

* Update taxjar_integration.py

Sider issues fix

* Sider issues fix

* Sider issues fix

* sider issue fix: unused import

* sider issue fix

* Update erpnext/erpnext_integrations/taxjar_integration.py

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

* Removed permission for 'All'

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
(cherry picked from commit 7004944)

# Conflicts:
#	erpnext/patches.txt
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* feat: Taxjar Integration update

* added taxable_amount,taxable_amount fields in setup.py

* Update taxjar_integration.py

Sider issues fix

* Sider issues fix

* Sider issues fix

* sider issue fix: unused import

* sider issue fix

* Update erpnext/erpnext_integrations/taxjar_integration.py

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>

* Removed permission for 'All'

Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
@ashish-greycube
Copy link
Contributor

on migration from 12 to 13..it gives following message

Executing execute:frappe.reload_doc("erpnext_integrations", "doctype", "Product Tax Category") in site1.local
/home/frappe/frappe-bench/apps/erpnext/erpnext/erpnext_integrations/doctype/product_tax_category/product_tax_category.json missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants