-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Taxjar Integration update #27143
Merged
deepeshgarg007
merged 9 commits into
frappe:develop
from
nemesis189:taxjar-integration-update
Aug 31, 2021
Merged
feat: Taxjar Integration update #27143
deepeshgarg007
merged 9 commits into
frappe:develop
from
nemesis189:taxjar-integration-update
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested changes
Aug 30, 2021
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
deepeshgarg007
requested review from
deepeshgarg007
and removed request for
nextchamp-saqib
August 31, 2021 05:18
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 31, 2021
* feat: Taxjar Integration update * added taxable_amount,taxable_amount fields in setup.py * Update taxjar_integration.py Sider issues fix * Sider issues fix * Sider issues fix * sider issue fix: unused import * sider issue fix * Update erpnext/erpnext_integrations/taxjar_integration.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> * Removed permission for 'All' Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> (cherry picked from commit 7004944) # Conflicts: # erpnext/patches.txt
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* feat: Taxjar Integration update * added taxable_amount,taxable_amount fields in setup.py * Update taxjar_integration.py Sider issues fix * Sider issues fix * Sider issues fix * sider issue fix: unused import * sider issue fix * Update erpnext/erpnext_integrations/taxjar_integration.py Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> * Removed permission for 'All' Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
on migration from 12 to 13..it gives following message
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaxJar is a platform that provides automated sales tax compliance, the api integration helps in auto-calculating sales tax in sales invoices. Primarily this integration is being developed to accommodate and ease taxation for the United States region.
ERPNext had the basic api integration setup, this update is to polish it further and make it fit for certification.
The tax rates are based on the states and products(product tax category).
Updates:
x-api-version
andplugin
parametersTaxJar Settings page in ERPNext
Product Tax Category field in Item Master
Sales Taxes and charges table auto populating with the rates
Taxable Amount and Tax Collectible retrieved form the response and stored
Transactions and breakdown on the TaxJar account transactions dashboard
docs: https://docs.erpnext.com/docs/v13/user/manual/en/erpnext_integration/new?wiki_page_patch=4eb79f3bef