-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated and empty QUnit tests #27179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
ChillarAnand,
deepeshgarg007,
marination,
nextchamp-saqib,
pateljannat,
rohitwaghchaure and
ruchamahabal
as code owners
August 26, 2021 13:48
Bulk deleted using: |
ankush
added
backport version-13-hotfix
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
labels
Aug 26, 2021
Testing library was added on Frappe, in order to reuse command testing library has to be installed during setup process.
nabinhait
approved these changes
Aug 26, 2021
UI test failures are irrelevant... will get it fixed separately. |
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Aug 26, 2021
* chore: remove deprecated and empty QUnit tests * ci: fix UI test config Testing library was added on Frappe, in order to reuse command testing library has to be installed during setup process. (cherry picked from commit ae55eab)
ankush
added a commit
that referenced
this pull request
Aug 26, 2021
* chore: remove deprecated and empty QUnit tests * ci: fix UI test config Testing library was added on Frappe, in order to reuse command testing library has to be installed during setup process. (cherry picked from commit ae55eab) Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* chore: remove deprecated and empty QUnit tests * ci: fix UI test config Testing library was added on Frappe, in order to reuse command testing library has to be installed during setup process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport version-13-hotfix
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all empty QUnit tests. They've been deprecated for some time now.
Non-empty tests are kept for reference for migration in future.