feat: (consistency) Add Primary Address and Contact section in Supplier #27197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marination
force-pushed
the
supplier-primary-address
branch
2 times, most recently
from
96633e2
to
bf72ec0
Compare
- The same is present in customer and is inconsistent with supplier - Helps quickly create primary address and contact via quick entry
- Include `supplier_quick_entry.js` in erpnext.bundle.js - Create primary supplier address on update - Set newly created address (quick entry) in Supplier and Customer - Clear address set in supplier and customer on delete (dependency)
marination
requested review from
ankush,
deepeshgarg007,
nextchamp-saqib and
rohitwaghchaure
as code owners
ankush
reviewed
Aug 27, 2021
- Sider: fixed indentation in js - Dont use f-strings in queries
ankush
approved these changes
Aug 30, 2021
|
Coveralls died for some reason. Not test failure. |
This was referenced Sep 1, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
feat: (consistency) Add Primary Address and Contact section in Supplier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same is present in customer and is inconsistent with supplier
Users can have multiple primary addresses against a supplier, they can choose one with the highest priority among them here
no-docs