Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use node action instead of apt #27220

Merged
merged 1 commit into from
Aug 30, 2021
Merged

ci: use node action instead of apt #27220

merged 1 commit into from
Aug 30, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Aug 30, 2021 •
edited
Loading

Replace manual node install in install.sh with https://github.com/actions/setup-node

@ankush ankush marked this pull request as draft August 30, 2021 05:54
@ankush ankush marked this pull request as ready for review August 30, 2021 06:13
@ankush ankush merged commit e5e0070 into frappe:develop Aug 30, 2021
@ankush ankush deleted the node_ci branch August 30, 2021 06:37
@coveralls
Copy link

coveralls commented Aug 30, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.001%) to 51.599% when pulling fe53c68 on ankush:node_ci into f5cdbf1 on frappe:develop.

frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 30, 2021
@ankush @frappe-bot
ci: use node action instead of apt (frappe#27220)
61ffab5 
(cherry picked from commit e5e0070)
@frappe-pr-bot frappe-pr-bot mentioned this pull request Aug 30, 2021
Merged
ankush added a commit that referenced this pull request Aug 30, 2021
@frappe-pr-bot @ankush
ci: use node action instead of apt (#27226)
dc948ca 
* ci: use node action instead of apt (#27220)

(cherry picked from commit e5e0070)

* ci: keep python version 3.6 for v13

* ci: use node v12

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
frappe-pr-bot added a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 30, 2021
@frappe-pr-bot @frappe-bot
ci: use node action instead of apt (frappe#27226)
6918a3d 
* ci: use node action instead of apt (frappe#27220)

(cherry picked from commit e5e0070)

* ci: keep python version 3.6 for v13

* ci: use node v12

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
(cherry picked from commit dc948ca)
ankush pushed a commit that referenced this pull request Aug 30, 2021
@frappe-pr-bot
ci: use node action instead of apt (#27226) (#27237)
03dcecf 
* ci: use node action instead of apt (#27220)

(cherry picked from commit e5e0070)

* ci: keep python version 3.6 for v13

* ci: use node v12

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
(cherry picked from commit dc948ca)
ahmadpak pushed a commit to Havenir/erpnext that referenced this pull request Aug 30, 2021
@ankush @ahmadpak
ci: use node action instead of apt (frappe#27220)
bbb997c
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush
ci: use node action instead of apt (frappe#27220)
b36a1cc
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankush @coveralls