-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup linting errors and introduce strict linting checks #27288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctype is not used in query and parent alone is enough to identify packed items.
ankush
force-pushed
the
strict_linting
branch
4 times, most recently
from
September 1, 2021 11:16
a0cebdb
to
5c1cc24
Compare
ankush
force-pushed
the
strict_linting
branch
from
September 1, 2021 11:27
5c1cc24
to
b147b85
Compare
ankush
requested review from
ChillarAnand,
deepeshgarg007,
marination,
nextchamp-saqib,
pateljannat,
rohitwaghchaure,
ruchamahabal and
surajshetty3416
as code owners
September 1, 2021 11:30
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
chore: cleanup linting errors and introduce strict linting checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: preventable errors passing through the review process. We use sider for these issues but sider is limited to "diff" while trying to be "diff-aware" it ignores the problem caused by the change in the same file.
Example:
def (a, b): + return a return a + b
Something like this would be totally acceptable to sider, but flake8 will warn you about dead code.
Solution:
Additional checks:
develop
directly. (common mistake by new contributors that leads to conflicts in future)To start using this install pre-commit using
pip install pre-commit
and then dopre-commit install
.TODO: