Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Removed healthcare module from ERPNext #27362

Merged
merged 9 commits into from
Oct 4, 2021
Merged

refactor!: Removed healthcare module from ERPNext #27362

merged 9 commits into from
Oct 4, 2021

Conversation

ChillarAnand
Copy link
Contributor

Healthcare app is available at https://github.com/frappe/healthcare.

Please raise new issues/PRs related to healthcare at the new repo.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 51.287% when pulling c8565c7 on ChillarAnand:care into b0d9700 on frappe:develop.

@ChillarAnand ChillarAnand marked this pull request as ready for review September 6, 2021 15:47
@ankush ankush changed the title chore: Removed healthcare module from ERPNext refactor!: Removed healthcare module from ERPNext Sep 6, 2021
@ruchamahabal ruchamahabal self-assigned this Sep 7, 2021
@iMoshi
Copy link

iMoshi commented Sep 7, 2021

Is this the way forward for ERPNext? Like become more modular-er..? :)

@ChillarAnand ChillarAnand mentioned this pull request Sep 17, 2021
Merged
@ChillarAnand
Copy link
Contributor Author

Closes earthians/marley#1

@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #27362 (01bea14) into develop (ab2adf0) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27362      +/-   ##
===========================================
- Coverage    54.61%   54.53%   -0.08%     
===========================================
  Files         1343     1248      -95     
  Lines        71048    67505    -3543     
===========================================
- Hits         38802    36814    -1988     
+ Misses       32246    30691    -1555
Impacted Files Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.81% <ø> (+1.38%) ⬆️
erpnext/controllers/queries.py 60.32% <ø> (+1.79%) ⬆️
...wise_balance_history/batch_wise_balance_history.py 69.49% <0.00%> (-23.73%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.52% <0.00%> (-3.58%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.50% <0.00%> (-2.50%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.92% <0.00%> (-1.44%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.48% <0.00%> (-0.75%) ⬇️
erpnext/accounts/party.py 76.74% <0.00%> (-0.59%) ⬇️
... and 53 more

ruchamahabal
ruchamahabal previously approved these changes Oct 4, 2021
View reviewed changes
ruchamahabal
ruchamahabal reviewed Oct 4, 2021
View reviewed changes
erpnext/hooks.py Outdated Show resolved Hide resolved
@ruchamahabal ruchamahabal merged commit 5905cf9 into frappe:develop Oct 4, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ruchamahabal
refactor!: Removed healthcare module from ERPNext (frappe#27362)
e6999d1 
* chore: Removed healthcare module

* chore: Removed healthcare demo, patch files

* chore: Rename imports from erpnext to healthcare

* chore: Added healthcare deprecation warning patch

* chore: Removed healthcare module code in other modules

* chore: Code clean up

* refactor: Remove sales invoice custom js related to healthcare

* fix: sider

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal left review comments

@pateljannat pateljannat Awaiting requested review from pateljannat

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@marination marination Awaiting requested review from marination

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees

@ruchamahabal ruchamahabal

Labels
healthcare
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChillarAnand @coveralls @iMoshi @ruchamahabal