Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added checkbox show remarks in the filters for AR & AP reports #27374

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

Anuja-pawar
Copy link
Contributor

@Anuja-pawar Anuja-pawar commented Sep 7, 2021

Added checkbox 'Show Remarks' in the filters to add column 'Remarks' whenever required in the reports Accounts Receivable & Accounts Payable.

ezgif com-gif-maker (4)

@deepeshgarg007
Copy link
Member

@Anuja-pawar This was recently removed by @rohitwaghchaure via #26679

@nextchamp-saqib
Copy link
Member

I remember it was removed due to performance reasons

@coveralls
Copy link

coveralls commented Sep 7, 2021

Coverage Status

Coverage decreased (-0.03%) to 51.617% when pulling a398cb5 on Anuja-pawar:AP-AR-reports into 2950204 on frappe:develop.

@Anuja-pawar Anuja-pawar changed the title fix: added remarks column in the reports Accounts Receivable & Accounts Payable fix: added checkbox show remarks in the filters for AR & AP reports Sep 8, 2021
@nextchamp-saqib nextchamp-saqib merged commit 3576668 into frappe:develop Sep 9, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 9, 2021
nextchamp-saqib pushed a commit that referenced this pull request Sep 9, 2021
(cherry picked from commit 3576668)

Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants