fix: Hero Slider Control & Alignment fixes #27611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariquerik
changed the title
|
@shariquerik @marination please review this at your earliest, we need to release this in our next release. @shariquerik please do check, if the buttons (Primary Button) work properly after the fix. |
Yes, primary button works fine after the fix, I have tested. |
marination
approved these changes
Oct 2, 2021
|
@Mergifyio backport version-13-hotfix |
|
@Mergifyio backport version-13-pre-release |
|
Command
|
|
Command
|
marination
added a commit
that referenced
this pull request
Oct 3, 2021
…-27611 fix: Hero Slider Control & Alignment fixes (backport #27611)
marination
added a commit
that referenced
this pull request
Oct 3, 2021
…se/pr-27611 fix: Hero Slider Control & Alignment fixes (backport #27611)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* fix: Creating unique hash for slider id instead of slider name * fix: Fixed alignment of Title, Subtitle, Action Button * chore: linter fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Cause:
In the current hero slider HTML, the slider has an
idattribute which is set asslider_name.Now if the slider name doesn't have any space (e.g. SliderName) in it then the left-right controls work, but if the slider name has space (e.g Slider Name) it doesn't work.
Solution:
Creating a unique hash for slider and setting it as
idinstead ofslider_nameCONTROLS
Before:
After:
ALIGNMENT
Before:
After:
