Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set item uom as stock_uom if it isn't set #27623

Merged
merged 3 commits into from
Oct 4, 2021
Merged

fix: set item uom as stock_uom if it isn't set #27623

merged 3 commits into from
Oct 4, 2021

Conversation

18alantom
Copy link
Member

  • UOM doesn't get set on Upload if it isn't present in the .csv but Stock UOM gets set.
  • This will copy the Stock UOM value to UOM if it isn't set.

@18alantom 18alantom added squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. old-backport version-12-hotfix and removed old-backport version-12-hotfix Unrelated Test(s) Failing Use when the failing test has nothing to do with PR. labels Sep 28, 2021
@18alantom 18alantom force-pushed the fix-set-uom-from-stock-uom-if-not-set branch from c2630e7 to 153eafa Compare October 4, 2021 11:52
ankush
ankush previously approved these changes Oct 4, 2021
View reviewed changes
@ankush ankush merged commit 5c37220 into frappe:develop Oct 4, 2021
mergify bot pushed a commit that referenced this pull request Oct 4, 2021
@18alantom
fix: set item uom as stock_uom if it isn't set (#27623)
4eb47ad 
* fix: set item uom as stock_uom if it isn't set

(cherry picked from commit 5c37220)
@mergify mergify bot mentioned this pull request Oct 4, 2021
Merged
mergify bot pushed a commit that referenced this pull request Oct 4, 2021
@18alantom
fix: set item uom as stock_uom if it isn't set (#27623)
6c4616a 
* fix: set item uom as stock_uom if it isn't set

(cherry picked from commit 5c37220)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/stock_entry.js
@mergify mergify bot mentioned this pull request Oct 4, 2021
Merged
@18alantom 18alantom deleted the fix-set-uom-from-stock-uom-if-not-set branch October 4, 2021 17:10
ankush pushed a commit that referenced this pull request Oct 4, 2021
@mergify @18alantom
fix: set item uom as stock_uom if it isn't set (#27623) (#27780)
91d269f 
* fix: set item uom as stock_uom if it isn't set

(cherry picked from commit 5c37220)

Co-authored-by: Alan <2.alan.tom@gmail.com>
ankush added a commit that referenced this pull request Oct 4, 2021
@mergify @18alantom @ankush
fix: set item uom as stock_uom if it isn't set (backport #27623) (#27781
d1480be 
)

* fix: set item uom as stock_uom if it isn't set (#27623)

* fix: set item uom as stock_uom if it isn't set

(cherry picked from commit 5c37220)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/stock_entry.js

* fix: resolve conflicts

[skip ci]

Co-authored-by: Alan <2.alan.tom@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
@rohitwaghchaure rohitwaghchaure mentioned this pull request Oct 30, 2021
Merged
@commit-lint commit-lint bot mentioned this pull request Nov 1, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@18alantom
fix: set item uom as stock_uom if it isn't set (frappe#27623)
4b87e65 
* fix: set item uom as stock_uom if it isn't set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush left review comments

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix old-backport version-12-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@18alantom @ankush