Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update variant qty in BOM, Create Work Order dialog #27686

Merged
merged 1 commit into from
Oct 1, 2021
Merged

fix: update variant qty in BOM, Create Work Order dialog #27686

merged 1 commit into from
Oct 1, 2021

Conversation

18alantom
Copy link
Member

Description

  • Create Work Order dialog doesn't update the qty of the variant item on updating fg qty.
  • Now it does on clicking away from the fg qty field.
Before
before_one.mov
After
after_one.mov

@18alantom
Copy link
Member Author

Sider issue is a false positive. (ref)

@18alantom
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

@ankush ankush merged commit ece446f into frappe:develop Oct 1, 2021
mergify bot pushed a commit that referenced this pull request Oct 1, 2021
@18alantom
fix: update variant qty in BOM, Create Work Order dialog (#27686)
98dadd9 
(cherry picked from commit ece446f)
@mergify mergify bot mentioned this pull request Oct 1, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2021

Command backport version-13-hotfix: success

Backports have been created

@frappe-pr-bot frappe-pr-bot mentioned this pull request Oct 1, 2021
Closed
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Oct 1, 2021
@18alantom @frappe-bot
fix: update variant qty in BOM, Create Work Order dialog (frappe#27686)
639f794 
(cherry picked from commit ece446f)
ankush pushed a commit that referenced this pull request Oct 1, 2021
@mergify @18alantom
fix: update variant qty in BOM, Create Work Order dialog (#27686) (#2…
e4f12f0 
…7732)

(cherry picked from commit ece446f)

Co-authored-by: Alan <2.alan.tom@gmail.com>
@rohitwaghchaure rohitwaghchaure mentioned this pull request Oct 20, 2021
Merged
@commit-lint commit-lint bot mentioned this pull request Oct 21, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@18alantom
fix: update variant qty in BOM, Create Work Order dialog (frappe#27686)
bb2e774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@18alantom @ankush