Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(India): Internal transfer check fix #27712

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Sep 30, 2021

If neither the Customer/Supplier nor the Company Address had a GSTIN added, then the transaction between these parties was wrongly considered an internal transaction.

Due to this when a PO was converted to Purchase Invoice, the taxes added in PO were removed when it got converted to Purchase Invoice

Steps to test:

  1. Add a Company Address with no GSTIN
  2. Add an address for a Supplier without GSTIN
  3. Make a Purchase Order, with that company (company should have country as India) add some taxes in it
  4. Using the menu option convert the Order to Invoice and make sure the same taxes from PO are copied in the invoice

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport develop

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2021

Command backport develop: pending

backport develop is pending

@deepeshgarg007 deepeshgarg007 merged commit f02438e into frappe:version-13-hotfix Oct 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2021

Command backport develop: success

Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 4, 2021
fix(India): Internal transfer check fix (backport #27712)
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2021

Command backport version-13-pre-release: success

Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 5, 2021
…se/pr-27712

fix(India): Internal transfer check fix (backport #27712)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix(India): Internal transfer check fix (backport frappe#27712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant