Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Website Items with same Item name unhandled, thumbnails missing #27720

Merged
merged 3 commits into from
Oct 3, 2021
Merged

fix: Website Items with same Item name unhandled, thumbnails missing #27720

merged 3 commits into from
Oct 3, 2021

Conversation

marination
Copy link
Collaborator

@marination marination commented Sep 30, 2021 •
edited
Loading

Website Item Naming

Issue:

  • If two items have different item codes and same item name, while creating website items via patch, it throws a Duplicate Error
  • This is because the website_item_name (copied from item name) is used to name the Website Item

Fix:

  • Use naming series for Website Item and re-run patch to make sure any pending items to be published are published.

Thumbnails missing

  • make_thumbnail was skipped in patches due to which Website Items have missing thumbnails
  • This impacts the cart, search, recommended items, etc.
    Fix:
  • In the website item creation patch (that will be re-run), for existing Website Items check if thumbnail is missing. If yes, trigger make_thumbnail
  • For new Website Items thumbnails will now be created after removing the patch condition in make_thumbnail

Miscellanous

  • Website Item Page (full page view) breaks if Enable Shopping Cart is disabled in E Commerce Settings
  • ‘Request for Quote’ button & cart summary not visible if Enable Checkout is disabled in E Commerce Settings

@marination
fix: Website Items with same Item name unhandled, thumbnails missing
36b519c 
- Use naming series for Website Item. There could be two items with same name and different item code
- Fix: Website Item Page view breaks if cart is disabled
- Fix: thumbnails not created for Website Items after patch
- Fix: ‘Request for Quote’ button & cart summary not visible if checkout is disabled
@marination marination mentioned this pull request Sep 30, 2021
Closed
@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Sep 30, 2021
@marination marination force-pushed the e-comm-web-item-name-thumbnail-fix branch 2 times, most recently from 9d359a7 to 77d4849 Compare October 3, 2021 07:59
@marination marination merged commit 4d0d642 into frappe:version-13-hotfix Oct 3, 2021
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-pre-release

@mergify mergify bot mentioned this pull request Oct 3, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2021

Command backport version-13-pre-release: success

Backports have been created

marination added a commit that referenced this pull request Oct 3, 2021
@marination
Merge pull request #27757 from frappe/mergify/bp/version-13-pre-relea…
68cce8e 
…se/pr-27720

fix: Website Items with same Item name unhandled, thumbnails missing (backport #27720)
@rohitwaghchaure rohitwaghchaure mentioned this pull request Oct 5, 2021
Merged
@rohitwaghchaure rohitwaghchaure mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marination