-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation #27728
Conversation
fix: Employee Leave Balance report showing wrong figures
Codecov Report
@@ Coverage Diff @@
## develop #27728 +/- ##
===========================================
- Coverage 54.63% 54.60% -0.03%
===========================================
Files 1343 1343
Lines 71040 71040
===========================================
- Hits 38813 38792 -21
- Misses 32227 32248 +21
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Do I need to do anything to get it going? |
@Mergifyio backport version-13-hotfix |
@Mergifyio backport version-12-hotfix |
🟠 Waiting for conditions
|
🟠 Waiting for conditions
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
…-27728 fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport #27728)
…-27728 fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport #27728)
…fix/pr-27728 fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport frappe#27728)
fix: Employee Leave Balance report showing wrong figures
We need to restrict the report to just pull the records which has transaction type 'Leave Allocation' only. Otherwise, the figures will be wrong.