Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation #27728

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

gohyc
Copy link
Contributor

@gohyc gohyc commented Oct 1, 2021

fix: Employee Leave Balance report showing wrong figures

We need to restrict the report to just pull the records which has transaction type 'Leave Allocation' only. Otherwise, the figures will be wrong.

fix: Employee Leave Balance report showing wrong figures
@gohyc gohyc changed the title Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures Oct 1, 2021
@pateljannat pateljannat self-assigned this Oct 1, 2021
@pateljannat pateljannat added the HR label Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #27728 (632f784) into develop (b9942ad) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #27728      +/-   ##
===========================================
- Coverage    54.63%   54.60%   -0.03%     
===========================================
  Files         1343     1343              
  Lines        71040    71040              
===========================================
- Hits         38813    38792      -21     
- Misses       32227    32248      +21     
Impacted Files Coverage Δ
...t/employee_leave_balance/employee_leave_balance.py 0.00% <ø> (ø)
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.55% <0.00%> (-2.95%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 90.09% <0.00%> (-1.99%) ⬇️
...doctype/healthcare_settings/healthcare_settings.py 60.65% <0.00%> (-1.64%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 88.48% <0.00%> (-1.44%) ⬇️
erpnext/assets/doctype/asset/asset.py 71.84% <0.00%> (-1.04%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 78.82% <0.00%> (-0.59%) ⬇️
erpnext/hr/utils.py 72.80% <0.00%> (-0.44%) ⬇️
erpnext/projects/doctype/project/project.py 53.90% <0.00%> (-0.36%) ⬇️
... and 14 more

@stale
Copy link

stale bot commented Oct 16, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 16, 2021
@gohyc
Copy link
Contributor Author

gohyc commented Oct 18, 2021

Do I need to do anything to get it going?

@stale stale bot removed the inactive label Oct 18, 2021
@pateljannat pateljannat changed the title fix: Employee Leave Balance report showing wrong figures fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation Oct 20, 2021
@pateljannat
Copy link
Contributor

@Mergifyio backport version-13-hotfix

@pateljannat
Copy link
Contributor

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-hotfix

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-12-hotfix

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@pateljannat
Copy link
Contributor

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-pre-release

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-hotfix

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-12-hotfix

✅ Backports have been created

pateljannat added a commit that referenced this pull request Oct 20, 2021
…-27728

fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport #27728)
pateljannat added a commit that referenced this pull request Oct 20, 2021
…-27728

fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport #27728)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27728

fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport frappe#27728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants