Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete linked Transaction Deletion Record docs on deleting company #27785

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

GangaManoj
Copy link
Contributor

Issue:

Users are unable to delete Companies with linked Transaction Deletion Record docs.

Screenshot 2021-10-05 at 10 16 25 AM

Fix:

Delete all Transaction Deletion Record docs associated with a company on deleting it.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #27785 (38c7e42) into develop (5905cf9) will decrease coverage by 0.06%.
The diff coverage is 90.90%.

@@             Coverage Diff             @@
##           develop   #27785      +/-   ##
===========================================
- Coverage    54.54%   54.47%   -0.07%     
===========================================
  Files         1248     1248              
  Lines        67517    67519       +2     
===========================================
- Hits         36830    36784      -46     
- Misses       30687    30735      +48     
Impacted Files Coverage Δ
erpnext/projects/doctype/timesheet/timesheet.py 79.35% <83.33%> (+0.16%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.70% <100.00%> (-0.11%) ⬇️
erpnext/setup/doctype/company/company.py 67.16% <100.00%> (+0.09%) ⬆️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.52% <0.00%> (-3.58%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 78.33% <0.00%> (-2.50%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
... and 11 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2021

Command backport version-13-hotfix: success

Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 5, 2021
…-27785

fix: Delete linked Transaction Deletion Record docs on deleting company (backport #27785)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix: Delete linked Transaction Deletion Record docs on deleting company
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants