Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Item Variant selection empty popup on website #27924

Merged

Conversation

marination
Copy link
Collaborator

Issue:

  • Screenshot 2021-10-12 at 7 59 26 PM
  • This was tested earlier with items that happened to have the same name as the website item
  • Website Item naming is now changed to naming series based. So this was missed.

Fix:

  • Store item_code instead of website item name in Select Variant buttons data attribute
  • It is used in get_attributes_and_values which was taking the website item name earlier and giving back a blank result.

Screenshot 2021-10-12 at 7 58 44 PM

- pass item_code instead of website item name to fetch attributes
@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Oct 12, 2021
@marination marination merged commit 8244980 into frappe:version-13-hotfix Oct 12, 2021
@nostahl
Copy link

nostahl commented Oct 15, 2021

ran into this issue as well after updating v13. after this hot fix applied the modal shows the variants now but clicking on the fields is empty.

@nostahl
Copy link

nostahl commented Oct 15, 2021

@marination is there an additional component to this hot fix that populates the variant selector field?

@marination
Copy link
Collaborator Author

@nostahl The variant items need to be published Website Items

@nostahl
Copy link

nostahl commented Oct 21, 2021

I notice in e commerce settings If I select "hide variants" and save it unchecked that box after save... i was able to get the template product to work now with the variants, I don't want all the variant products showing as individual products on the site etc.

@nostahl
Copy link

nostahl commented Oct 22, 2021

ahh all seems to be working with 13.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants