-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TDS round off not working from second transaction #27934
Merged
deepeshgarg007
merged 2 commits into
frappe:develop
from
deepeshgarg007:tds_round_off_error
Oct 18, 2021
Merged
fix: TDS round off not working from second transaction #27934
deepeshgarg007
merged 2 commits into
frappe:develop
from
deepeshgarg007:tds_round_off_error
Oct 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
force-pushed
the
tds_round_off_error
branch
from
October 13, 2021 06:30
5b18cff
to
ca00672
Compare
Codecov Report
@@ Coverage Diff @@
## develop #27934 +/- ##
===========================================
- Coverage 54.55% 54.42% -0.14%
===========================================
Files 1248 1255 +7
Lines 67518 67817 +299
===========================================
+ Hits 36836 36907 +71
- Misses 30682 30910 +228
|
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions
|
✅ Backports have been created
|
This was referenced Oct 18, 2021
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Oct 18, 2021
…-27934 fix: TDS round off not working from second transaction (backport #27934)
deepeshgarg007
added a commit
that referenced
this pull request
Oct 18, 2021
…se/pr-27934 fix: TDS round off not working from second transaction (backport #27934)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…fix/pr-27934 fix: TDS round off not working from second transaction (backport frappe#27934)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tax Withholding Round Off amount check was done only in the code block where the TDS for the very first transaction was calculated.
So for the subsequent transactions let's say second and so on the TDS amount was not getting rounded to the nearest integer
Moved the check to the code block where the final tax amount is returned so that the tax amount is rounded off for all types (TDS and TCS both) and all transactions