Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Account number and name incorrectly imported using COA importer #27967

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 15, 2021

Account name and number were not correctly updated in the Account master when accounts were imported using the chart of accounts importer tool

For Eg: If an account name is Test Account and account number is 1234 the account numbers is imported as blank and the account name is imported as 1234 - Test Account

This PR fixes that issue

@deepeshgarg007 deepeshgarg007 changed the title fix: Account number and name incorrectly import using COA importer fix: Account number and name incorrectly imported using COA importer Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #27967 (17a8649) into develop (6019f60) will decrease coverage by 0.15%.
The diff coverage is 27.27%.

@@             Coverage Diff             @@
##           develop   #27967      +/-   ##
===========================================
- Coverage    54.55%   54.39%   -0.16%     
===========================================
  Files         1248     1255       +7     
  Lines        67518    67822     +304     
===========================================
+ Hits         36836    36895      +59     
- Misses       30682    30927     +245     
Impacted Files Coverage Δ
...of_accounts_importer/chart_of_accounts_importer.py 0.00% <0.00%> (ø)
...ype/account/chart_of_accounts/chart_of_accounts.py 78.23% <50.00%> (-0.39%) ⬇️
...ctype/product_tax_category/product_tax_category.py 0.00% <0.00%> (-100.00%) ⬇️
...rations/doctype/taxjar_settings/taxjar_settings.py 29.50% <0.00%> (-70.50%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/shopping_cart/utils.py 32.14% <0.00%> (-3.58%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
... and 39 more

@deepeshgarg007 deepeshgarg007 merged commit 9c54d6d into frappe:develop Oct 18, 2021
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-hotfix

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-pre-release

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 18, 2021
…-27967

fix: Account number and name incorrectly imported using COA importer (backport #27967)
deepeshgarg007 added a commit that referenced this pull request Oct 18, 2021
…se/pr-27967

fix: Account number and name incorrectly imported using COA importer (backport #27967)
@Ponyooooo
Copy link

have installed a new erpnext with the v13.13.0, and the chart of accounts imported did not recognize or maybe made all accounts as "is group" is 1. So all accounts imported are in group.

@Olawale1
Copy link

Hi @deepeshgarg007

The issue reported by @Ponyooooo is a serious one and we just encountered same now. All our ledgers are now imported as Group which means we can't post anything into them! Please help fix this urgently!

Thanks

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27967

fix: Account number and name incorrectly imported using COA importer (backport frappe#27967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants