Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect VAT Amount in UAT VAT 201 report #27994

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Oct 18, 2021

Total taxes and charges is added repeatedly for every item.
Issue reported in detail by user at https://discuss.erpnext.com/t/uae-vat-report-issue-vat-amount-wrong/81415

Tests should've included multiple items in the invoices to catch this error. #ToDo

Closes #27973
#no-docs

@rtdany10
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-hotfix

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@rtdany10 rtdany10 marked this pull request as draft October 19, 2021 08:13
@rtdany10 rtdany10 marked this pull request as ready for review October 19, 2021 08:44
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #27994 (d734da9) into develop (01bb97b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #27994   +/-   ##
========================================
  Coverage    54.41%   54.42%           
========================================
  Files         1255     1255           
  Lines        67822    67822           
========================================
+ Hits         36904    36910    +6     
+ Misses       30918    30912    -6     
Impacted Files Coverage Δ
erpnext/regional/report/uae_vat_201/uae_vat_201.py 46.80% <ø> (ø)
erpnext/selling/doctype/sales_order/sales_order.py 76.39% <0.00%> (-0.75%) ⬇️
erpnext/stock/stock_ledger.py 85.35% <0.00%> (-0.73%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.36% <0.00%> (-0.72%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.55% <0.00%> (-0.69%) ⬇️
erpnext/projects/doctype/project/project.py 54.25% <0.00%> (-0.36%) ⬇️
erpnext/stock/get_item_details.py 79.38% <0.00%> (-0.16%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.61% <0.00%> (ø)
.../report/accounts_receivable/accounts_receivable.py 68.34% <0.00%> (+0.43%) ⬆️
...next/accounts/doctype/subscription/subscription.py 82.58% <0.00%> (+0.56%) ⬆️
... and 8 more

@deepeshgarg007 deepeshgarg007 self-assigned this Oct 19, 2021
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 29, 2021
…-27994

fix: incorrect VAT Amount in UAE VAT 201 report (backport #27994)
@rtdany10 rtdany10 deleted the patch-8 branch November 5, 2021 03:13
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27994

fix: incorrect VAT Amount in UAE VAT 201 report (backport frappe#27994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UAE VAT 201 Report issue
2 participants