-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect VAT Amount in UAT VAT 201 report #27994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtdany10
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
October 18, 2021 13:26
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions
|
Codecov Report
@@ Coverage Diff @@
## develop #27994 +/- ##
========================================
Coverage 54.41% 54.42%
========================================
Files 1255 1255
Lines 67822 67822
========================================
+ Hits 36904 36910 +6
+ Misses 30918 30912 -6
|
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Oct 29, 2021
…-27994 fix: incorrect VAT Amount in UAE VAT 201 report (backport #27994)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…fix/pr-27994 fix: incorrect VAT Amount in UAE VAT 201 report (backport frappe#27994)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total taxes and charges is added repeatedly for every item.
Issue reported in detail by user at https://discuss.erpnext.com/t/uae-vat-report-issue-vat-amount-wrong/81415
Tests should've included multiple items in the invoices to catch this error. #ToDo
Closes #27973
#no-docs