Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove hub #28117

Merged
merged 3 commits into from
Oct 28, 2021
Merged

refactor!: remove hub #28117

merged 3 commits into from
Oct 28, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 27, 2021

RIP

@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #28117 (27860ef) into develop (d81b87d) will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28117      +/-   ##
===========================================
+ Coverage    55.16%   55.32%   +0.15%     
===========================================
  Files         1255     1248       -7     
  Lines        67934    67680     -254     
===========================================
- Hits         37478    37446      -32     
+ Misses       30456    30234     -222     
Impacted Files Coverage Δ
.../setup/setup_wizard/operations/install_fixtures.py 92.99% <ø> (ø)
erpnext/stock/doctype/item/item.py 66.71% <ø> (-0.05%) ⬇️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/accounts/doctype/pricing_rule/utils.py 69.78% <0.00%> (-0.54%) ⬇️
erpnext/portal/product_configurator/utils.py 33.06% <0.00%> (-0.41%) ⬇️
erpnext/hr/utils.py 74.29% <0.00%> (-0.41%) ⬇️
... and 10 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant