feat: provision to close the Work Order #28150

anupamvs · 2021-10-29T11:57:50Z

Added a provision to permanently close a Work Order. It can not be restarted once it is closed.

[no-docs]

codecov · 2021-10-29T12:19:00Z

Codecov Report

Merging #28150 (092936d) into develop (0e8e7e2) will increase coverage by 16.06%.
The diff coverage is 39.28%.

@@             Coverage Diff              @@
##           develop   #28150       +/-   ##
============================================
+ Coverage    39.13%   55.19%   +16.06%     
============================================
  Files         1117     1117               
  Lines        66494    66520       +26     
============================================
+ Hits         26021    36715    +10694     
+ Misses       40473    29805    -10668

Impacted Files	Coverage Δ
erpnext/stock/stock_balance.py	`50.00% <ø> (ø)`
...ext/manufacturing/doctype/work_order/work_order.py	`71.90% <17.64%> (+28.32%)`	⬆️
erpnext/manufacturing/doctype/job_card/job_card.py	`64.67% <72.72%> (+50.86%)`	⬆️
...wise_balance_history/batch_wise_balance_history.py	`68.96% <0.00%> (-22.42%)`	⬇️
.../report/stock_projected_qty/stock_projected_qty.py	`88.15% <0.00%> (-1.32%)`	⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py	`77.24% <0.00%> (-0.69%)`	⬇️
.../report/accounts_receivable/accounts_receivable.py	`67.83% <0.00%> (-0.44%)`	⬇️
erpnext/setup/doctype/company/company.py	`71.71% <0.00%> (+0.32%)`	⬆️
...next/accounts/doctype/pricing_rule/pricing_rule.py	`64.85% <0.00%> (+0.36%)`	⬆️
...cturing/doctype/production_plan/production_plan.py	`69.44% <0.00%> (+0.59%)`	⬆️
... and 308 more

rohitwaghchaure · 2021-10-30T09:59:20Z

@anupamvs please add description and fix sider issues

ankush · 2021-10-31T09:45:53Z

Now list view should hide closed WOs by default?

anupamvs · 2021-10-31T11:43:14Z

@Mergifyio backport version-13-pre-release

anupamvs · 2021-10-31T11:43:26Z

@Mergifyio backport version-13-hotfix

mergify · 2021-10-31T11:43:55Z

backport version-13-pre-release

🟠 Waiting for conditions to match

merged [:pushpin: backport requirement]

mergify · 2021-10-31T11:43:56Z

backport version-13-hotfix

🟠 Waiting for conditions to match

merged [:pushpin: backport requirement]

mergify · 2021-11-09T10:16:29Z

backport version-13-pre-release

✅ Backports have been created

#28290 feat: provision to close the Work Order (backport #28150) has been created for branch version-13-pre-release

mergify · 2021-11-09T10:17:13Z

backport version-13-hotfix

✅ Backports have been created

#28291 feat: provision to close the Work Order (backport #28150) has been created for branch version-13-hotfix

…se/pr-28150 feat: provision to close the Work Order (backport #28150)

…-28150 feat: provision to close the Work Order (backport #28150)

…-release/pr-28150 feat: provision to close the Work Order (backport frappe#28150)

feat: provision to close the Work Order

23af036

anupamvs requested review from ankush, marination and rohitwaghchaure as code owners October 29, 2021 11:57

anupamvs added 2 commits October 31, 2021 14:20

feat: added confirm dialog on closing of workorder

5d4c565

fix: sider issue

e290fe0

anupamvs force-pushed the manufacturing-work-order-stop branch from 048f774 to e290fe0 Compare October 31, 2021 09:12

fix: sider issue

55e97dc

fix: sider issue

264b0df

rohitwaghchaure added the needs-tests This PR needs automated unit-tests. label Nov 1, 2021

fix: added testcase

530a0f4

anupamvs force-pushed the manufacturing-work-order-stop branch from 6ed4d81 to 530a0f4 Compare November 2, 2021 07:09

fix: linter issues

59e4fd9

anupamvs force-pushed the manufacturing-work-order-stop branch from 84cda62 to 59e4fd9 Compare November 2, 2021 07:16

fix: linter issues

e36da4d

anupamvs force-pushed the manufacturing-work-order-stop branch from ac94a44 to e36da4d Compare November 2, 2021 07:23

fix: test cases

9c0906f

anupamvs force-pushed the manufacturing-work-order-stop branch from 9b063e9 to 9c0906f Compare November 2, 2021 15:13

fix: validate job card

9b4c7e4

anupamvs force-pushed the manufacturing-work-order-stop branch from 756c235 to 9b4c7e4 Compare November 3, 2021 07:58

fix: sider isuue

ba47bd0

anupamvs force-pushed the manufacturing-work-order-stop branch from 4ee3ad9 to ba47bd0 Compare November 3, 2021 08:11

Merge branch 'develop' into manufacturing-work-order-stop

8ebc412

fix: linter isuue

cc15cf6

anupamvs removed the needs-tests This PR needs automated unit-tests. label Nov 3, 2021

fix: testcases:

7044ae5

rohitwaghchaure added the CI-failing Unit tests or patch tests are failing. label Nov 7, 2021

fix: test cases

27709a1

rohitwaghchaure added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Nov 9, 2021

rohitwaghchaure previously approved these changes Nov 9, 2021

View reviewed changes

fix: get_planned_qty chnages

663a7af

anupamvs dismissed rohitwaghchaure’s stale review via 663a7af November 9, 2021 05:21

anupamvs force-pushed the manufacturing-work-order-stop branch from 38dd4ab to 663a7af Compare November 9, 2021 05:21

Merge branch 'develop' into manufacturing-work-order-stop

092936d

anupamvs removed the CI-failing Unit tests or patch tests are failing. label Nov 9, 2021

rohitwaghchaure merged commit f57538b into frappe:develop Nov 9, 2021

mergify bot mentioned this pull request Nov 9, 2021

feat: provision to close the Work Order (backport #28150) #28290

Merged

mergify bot mentioned this pull request Nov 9, 2021

feat: provision to close the Work Order (backport #28150) #28291

Merged

rohitwaghchaure added a commit that referenced this pull request Nov 9, 2021

Merge pull request #28290 from frappe/mergify/bp/version-13-pre-relea…

346c76c

…se/pr-28150 feat: provision to close the Work Order (backport #28150)

rohitwaghchaure added a commit that referenced this pull request Nov 9, 2021

Merge pull request #28291 from frappe/mergify/bp/version-13-hotfix/pr…

9869b17

…-28150 feat: provision to close the Work Order (backport #28150)

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021

Merge pull request frappe#28290 from frappe/mergify/bp/version-13-pre…

323e61a

…-release/pr-28150 feat: provision to close the Work Order (backport frappe#28150)

ankush mentioned this pull request Nov 20, 2021

fix: Closed status error in Work Order Summary #28460

Merged

ankush mentioned this pull request Feb 9, 2022

fix: Reserved for Production calculation considered closed work orders #29715

Merged

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: provision to close the Work Order #28150

feat: provision to close the Work Order #28150

anupamvs commented Oct 29, 2021 •

edited

Loading

codecov bot commented Oct 29, 2021 •

edited

Loading

rohitwaghchaure commented Oct 30, 2021 •

edited

Loading

ankush commented Oct 31, 2021

anupamvs commented Oct 31, 2021

anupamvs commented Oct 31, 2021

mergify bot commented Oct 31, 2021

mergify bot commented Oct 31, 2021

mergify bot commented Nov 9, 2021

mergify bot commented Nov 9, 2021

feat: provision to close the Work Order #28150

feat: provision to close the Work Order #28150

Conversation

anupamvs commented Oct 29, 2021 • edited Loading

codecov bot commented Oct 29, 2021 • edited Loading

Codecov Report

rohitwaghchaure commented Oct 30, 2021 • edited Loading

ankush commented Oct 31, 2021

anupamvs commented Oct 31, 2021

anupamvs commented Oct 31, 2021

mergify bot commented Oct 31, 2021

🟠 Waiting for conditions to match

mergify bot commented Oct 31, 2021

🟠 Waiting for conditions to match

mergify bot commented Nov 9, 2021

✅ Backports have been created

mergify bot commented Nov 9, 2021

✅ Backports have been created

anupamvs commented Oct 29, 2021 •

edited

Loading

codecov bot commented Oct 29, 2021 •

edited

Loading

rohitwaghchaure commented Oct 30, 2021 •

edited

Loading