-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Serial Nos not set in the row after scanning in popup #28202
Merged
marination
merged 1 commit into
frappe:develop
from
marination:serial-no-popup-with-scanner
Nov 2, 2021
Merged
fix: Serial Nos not set in the row after scanning in popup #28202
marination
merged 1 commit into
frappe:develop
from
marination:serial-no-popup-with-scanner
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid whitspaces while calculating length of serial nos
marination
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
November 2, 2021 14:17
@Mergifyio backport version-13-hotfix |
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions to match
|
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Nov 2, 2021
…-28202 fix: Serial Nos not set in the row after scanning in popup (backport #28202)
marination
added a commit
that referenced
this pull request
Nov 2, 2021
…se/pr-28202 fix: Serial Nos not set in the row after scanning in popup (backport #28202)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…-release/pr-28202 fix: Serial Nos not set in the row after scanning in popup (backport frappe#28202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
At the end press enter (go to next line
? The culprit.serial_nos = ['123', '456', '']
. Ideally the length here is 2, but the extra string makes the length 3. Hence not equal to length, hence empty fieldFix: