Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve financial statement loading time #28238

Merged

Conversation

nextchamp-saqib
Copy link
Member

Remove sorting from SQL query while fetching the ledger entries, since balances of these entries are going to be consolidated by account, later on, so sorted entries aren't necessary

This reduced the loading time of a Trial Balance report from ~18 secs to ~7secs so around 60% improvement

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #28238 (b7a44fe) into develop (a5902fa) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28238      +/-   ##
===========================================
- Coverage    55.45%   55.43%   -0.03%     
===========================================
  Files         1248     1248              
  Lines        67756    67756              
===========================================
- Hits         37577    37561      -16     
- Misses       30179    30195      +16     
Impacted Files Coverage Δ
erpnext/accounts/report/financial_statements.py 30.45% <ø> (ø)
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-2.60%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.59% <0.00%> (-2.47%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
... and 23 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants