Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Let serialised Items be consumed during Asset Repairs #28349

Merged
merged 14 commits into from
Nov 29, 2021

Conversation

GangaManoj
Copy link
Contributor

@GangaManoj GangaManoj commented Nov 11, 2021

Problem

While repairing Assets, users might need to consume Stock Items already in their possession(eg: nuts and bolts). The Stock Consumption Details section exists to record such information and decrease stock quantity for the consumed Items. However, this feature can currently only be used for non-serialised Items.

Stock Consumption Details section

Screenshot 2021-11-25 at 7 25 59 PM

Error Message

The following error is raised when Users attempt to submit Asset Repairs which have consumed Serialized Items:

Screenshot 2021-11-11 at 6 55 32 PM

Proposed Change

Allow users to consume Serialized Items during Asset Repairs by:

  • Adding a Serial No field
  • Adding an Add Serial No button, which prompts the user to enter the Serial Now of their choice
Images

Screenshot 2021-11-11 at 7 00 05 PM

Screenshot 2021-11-11 at 7 00 57 PM

ToDo
Testing Info
  1. Create a Serialized Item
  2. Submit Stock Entry of type Material Receipt for it(or just create Serial No docs)
  3. Create an Asset
  4. Create an Asset Repair for it
  5. Check the Stock Consumed During Repair box
  6. Enter the Serialized Item in the Stock Items table

On trying to submit it at this stage, the following error will be raised:
Screenshot 2021-11-11 at 6 55 32 PM

  1. Expand the row for the Serialized Item
  2. Click on the Add Serial No button and select the Serial No of your choice
  3. Save and Submit

This time, you should be able to submit the Asset Repair.

no-docs

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #28349 (7a15f85) into develop (0d9b0fe) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28349      +/-   ##
===========================================
- Coverage    55.21%   55.15%   -0.07%     
===========================================
  Files         1121     1121              
  Lines        66746    66746              
===========================================
- Hits         36856    36813      -43     
- Misses       29890    29933      +43     
Impacted Files Coverage Δ
...rpnext/assets/doctype/asset_repair/asset_repair.py 63.57% <ø> (ø)
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-2.98%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 88.32% <0.00%> (-2.92%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-2.44%) ⬇️
... and 16 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants