-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Let serialised Items be consumed during Asset Repairs #28349
Merged
nextchamp-saqib
merged 14 commits into
frappe:develop
from
GangaManoj:serialized-item-consumption
Nov 29, 2021
Merged
feat: Let serialised Items be consumed during Asset Repairs #28349
nextchamp-saqib
merged 14 commits into
frappe:develop
from
GangaManoj:serialized-item-consumption
Nov 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GangaManoj
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
November 11, 2021 13:33
Codecov Report
@@ Coverage Diff @@
## develop #28349 +/- ##
===========================================
- Coverage 55.21% 55.15% -0.07%
===========================================
Files 1121 1121
Lines 66746 66746
===========================================
- Hits 36856 36813 -43
- Misses 29890 29933 +43
|
ankush
added a commit
that referenced
this pull request
Nov 30, 2021
…-28349 feat: Let serialised Items be consumed during Asset Repairs (backport #28349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While repairing Assets, users might need to consume Stock Items already in their possession(eg: nuts and bolts). The Stock Consumption Details section exists to record such information and decrease stock quantity for the consumed Items. However, this feature can currently only be used for non-serialised Items.
Stock Consumption Details section
Error Message
The following error is raised when Users attempt to submit Asset Repairs which have consumed Serialized Items:
Proposed Change
Allow users to consume Serialized Items during Asset Repairs by:
Images
ToDo
Testing Info
On trying to submit it at this stage, the following error will be raised:
This time, you should be able to submit the Asset Repair.
no-docs