Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: carry forward communication and comments throughout the sales c… #28458

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Nov 19, 2021

When converting a Lead into Opportunity and Opportunity to Quotation, the system will auto copy the emails and comments from the source doc.

crm

CRM Settings-
image

docs- https://docs.erpnext.com/docs/v13/user/manual/en/CRM/crm_settings#other-settings

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #28458 (2fd870f) into develop (88df5ce) will decrease coverage by 0.00%.
The diff coverage is 86.48%.

@@             Coverage Diff             @@
##           develop   #28458      +/-   ##
===========================================
- Coverage    55.67%   55.67%   -0.01%     
===========================================
  Files         1128     1128              
  Lines        67335    67372      +37     
===========================================
+ Hits         37488    37506      +18     
- Misses       29847    29866      +19     
Impacted Files Coverage Δ
erpnext/crm/doctype/prospect/prospect.py 56.71% <66.66%> (+0.97%) ⬆️
erpnext/selling/doctype/quotation/quotation.py 49.18% <66.66%> (+2.03%) ⬆️
erpnext/crm/doctype/opportunity/opportunity.py 70.42% <100.00%> (-0.74%) ⬇️
erpnext/crm/utils.py 66.66% <100.00%> (+35.41%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-0.86%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.23% <0.00%> (-0.82%) ⬇️
... and 14 more

@anupamvs anupamvs removed the WIP label Nov 30, 2021
@rohitwaghchaure
Copy link
Collaborator

@anupamvs, add test cases and docs

@anupamvs anupamvs force-pushed the crm-carry-forward-communication-comments branch from b0da101 to e4ee55c Compare December 21, 2021 05:57
@anupamvs
Copy link
Contributor Author

@rohitwaghchaure can you review it?

@rohitwaghchaure rohitwaghchaure merged commit 650b388 into frappe:develop Jan 3, 2022
@anupamvs anupamvs linked an issue Jan 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portability Of Notes and Communication in CRM
2 participants