-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bulk Transaction Processing #28580
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28580 +/- ##
===========================================
- Coverage 58.03% 58.02% -0.02%
===========================================
Files 1091 1095 +4
Lines 67866 68003 +137
===========================================
+ Hits 39388 39459 +71
- Misses 28478 28544 +66
|
300 sider issues 😱 Just pass new files through something like https://prettier.io/ to auto format them. |
reopen after resolving open issues + some basic tests. JS code also seems to be duplicated across many different doctype.js files. Maybe create a JS util class / function somewhere? |
15e6b78
to
cb2ba8c
Compare
Eye on this |
erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.js
Outdated
Show resolved
Hide resolved
.distinct() | ||
.where(btp.retried != 1) | ||
.where(btp.transaction_status == "Failed") | ||
.where(btp.date == fn.CurDate()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can only retry what failed today? Any reason for this restriction? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for retrying all failing transaction log from list view; IMO
- It should signify it will only attempt today's failed transaction.
- Single log should also have retry. (feature request)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't show all the transactions at once. so the user can retry that specific date's failing transaction
Can they though? The query only appears to retry today's failed transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it did not but now I have made the changes to retry that specific date's transaction
Before this Feature
Lets take an example to get better idea
Tasks
Following operations can be performed in bulk:
After this Feature