feat: added QI link in Job Card Dashboard #28643

noahjacob · 2021-11-30T09:25:40Z

Changes

Added a Quality Inspection link in the Job Card Dashboard.

no_docs

codecov · 2021-11-30T09:49:31Z

Codecov Report

Merging #28643 (73894d5) into develop (37c318a) will increase coverage by 13.88%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #28643       +/-   ##
============================================
+ Coverage    41.34%   55.23%   +13.88%     
============================================
  Files         1120     1121        +1     
  Lines        66673    66746       +73     
============================================
+ Hits         27567    36868     +9301     
+ Misses       39106    29878     -9228

Impacted Files	Coverage Δ
.../report/stock_projected_qty/stock_projected_qty.py	`86.84% <0.00%> (-2.64%)`	⬇️
...next/accounts/doctype/subscription/subscription.py	`81.74% <0.00%> (-0.57%)`	⬇️
.../report/accounts_receivable/accounts_receivable.py	`67.83% <0.00%> (-0.44%)`	⬇️
erpnext/regional/saudi_arabia/utils.py	`24.05% <0.00%> (-0.40%)`	⬇️
erpnext/hooks.py	`0.00% <0.00%> (ø)`
...onsumed_materials/work_order_consumed_materials.py	`0.00% <0.00%> (ø)`
erpnext/controllers/item_variant.py	`70.76% <0.00%> (+0.51%)`	⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py	`90.56% <0.00%> (+0.53%)`	⬆️
...xt/hr/doctype/employee_advance/employee_advance.py	`66.94% <0.00%> (+0.55%)`	⬆️
...xt/buying/doctype/purchase_order/purchase_order.py	`78.30% <0.00%> (+0.56%)`	⬆️
... and 319 more

(cherry picked from commit f1c0190)

(cherry picked from commit f1c0190) Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>

* feat: added QI link in Job Card Dashboard (backport frappe#28643) * feat: Show Zero Values filter in consolidated financial statement (cherry picked from commit 9610086) * fix: ensure that reposting is finished before freezing stock/account (cherry picked from commit d37541d) * test: stock frozen validation (cherry picked from commit 75bc404) * fix: incorrect outgoing rates when material_consumption enabled (cherry picked from commit 7f3e6d1) * test: added tests for manufacture stock entry when material_consumption is enabled (cherry picked from commit 35346de) * fix: actual tax conversion in case of multicurrency invoices (backport frappe#28539) * fix: Shipping Rule picking up old net_rate (cherry picked from commit c78b8b7) * fix: calling shipping rule method during net_total calculation in taxes_adn_totals.py (cherry picked from commit 18ae03d) * fix: check if shipping rule value exists (cherry picked from commit af1fce0) * fix: fixed tests, separated a method for shipping charges (cherry picked from commit a8e2c02) * fix: sider issues (cherry picked from commit e7b4204) * fix: merge conflicts * fix: Paid showing in AR/AP report * fix: Better Error logging fordeferred revenue/expense booking (cherry picked from commit 67a001d) * fix: Commit joural entries (cherry picked from commit 0ba4fce) * fix: Log error before throwing exception (cherry picked from commit 3c64e20) * fix: mapping to maintenance visit gets erased (backport frappe#28917) * fix: ignore mandatory fields while creating WO from SO (backport frappe#28772) * refactor: map serial from schedule if only one (backport frappe#28745) * fix: TDS Monthly payable report (backport frappe#28764) * fix: Maintenance Visit purposes tables is not visible on submission (backport frappe#28792) * fix: misleading "Set Default X" fields after saving (backport frappe#28798) * fix: Fix depreciation_amount calculation (cherry picked from commit 22cc8d2) # Conflicts: # erpnext/regional/india/utils.py * fix: Create Depreciation Schedules properly for existing Assets (cherry picked from commit 5c3d4ca) * fix: Modify has_pro_rata() to include existing assets (cherry picked from commit de00200) * fix: Test if depreciation schedules are set up properly for existing assets (cherry picked from commit 774ac85) # Conflicts: # erpnext/assets/doctype/asset/test_asset.py * fix: Remove unnecessary variable (cherry picked from commit 828769c) * fix: conflicts * fix: conflicts * feat: Add Serial No field (cherry picked from commit 1aed8c4) * fix: Rename item to item_code (cherry picked from commit abb5355) * feat: Add 'Add Serial No' button in the Stock Items table (cherry picked from commit 4668bb4) * fix: Add serial no to Stock Entry doc to decrease quantity for Stock Items consumed during repair (cherry picked from commit 1393f97) * fix: Replace 'item' with 'item_code' in tests (cherry picked from commit c9e79ef) * fix: Create stock item (cherry picked from commit eea80b6) * fix: Create setUpClass (cherry picked from commit efac7b0) * fix: Add test for consumption of serialized Assets (cherry picked from commit 6b75d14) * fix: Remove unused import (cherry picked from commit b28f137) * fix: Change order of import statements (cherry picked from commit c94f1ed) * Merge pull request frappe#29257 from marination/fix-reset-wh-defaults fix: Avoid resetting Default wh fields for Manufacture Entry (cherry picked from commit efcfb82) Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Marica <maricadsouza221197@gmail.com>

* feat: added QI link in Job Card Dashboard (backport frappe#28643) * feat: Show Zero Values filter in consolidated financial statement (cherry picked from commit 9610086) * fix: ensure that reposting is finished before freezing stock/account (cherry picked from commit d37541d) * test: stock frozen validation (cherry picked from commit 75bc404) * fix: incorrect outgoing rates when material_consumption enabled (cherry picked from commit 7f3e6d1) * test: added tests for manufacture stock entry when material_consumption is enabled (cherry picked from commit 35346de) * fix: actual tax conversion in case of multicurrency invoices (backport frappe#28539) * fix: Shipping Rule picking up old net_rate (cherry picked from commit c78b8b7) * fix: calling shipping rule method during net_total calculation in taxes_adn_totals.py (cherry picked from commit 18ae03d) * fix: check if shipping rule value exists (cherry picked from commit af1fce0) * fix: fixed tests, separated a method for shipping charges (cherry picked from commit a8e2c02) * fix: sider issues (cherry picked from commit e7b4204) * fix: merge conflicts * fix: Paid showing in AR/AP report * fix: Better Error logging fordeferred revenue/expense booking (cherry picked from commit 67a001d) * fix: Commit joural entries (cherry picked from commit 0ba4fce) * fix: Log error before throwing exception (cherry picked from commit 3c64e20) * fix: mapping to maintenance visit gets erased (backport frappe#28917) * fix: ignore mandatory fields while creating WO from SO (backport frappe#28772) * refactor: map serial from schedule if only one (backport frappe#28745) * fix: TDS Monthly payable report (backport frappe#28764) * fix: Maintenance Visit purposes tables is not visible on submission (backport frappe#28792) * fix: misleading "Set Default X" fields after saving (backport frappe#28798) * fix: Fix depreciation_amount calculation (cherry picked from commit 22cc8d2) * fix: Create Depreciation Schedules properly for existing Assets (cherry picked from commit 5c3d4ca) * fix: Modify has_pro_rata() to include existing assets (cherry picked from commit de00200) * fix: Test if depreciation schedules are set up properly for existing assets (cherry picked from commit 774ac85) * fix: Remove unnecessary variable (cherry picked from commit 828769c) * fix: conflicts * fix: conflicts * feat: Add Serial No field (cherry picked from commit 1aed8c4) * fix: Rename item to item_code (cherry picked from commit abb5355) * feat: Add 'Add Serial No' button in the Stock Items table (cherry picked from commit 4668bb4) * fix: Add serial no to Stock Entry doc to decrease quantity for Stock Items consumed during repair (cherry picked from commit 1393f97) * fix: Replace 'item' with 'item_code' in tests (cherry picked from commit c9e79ef) * fix: Create stock item (cherry picked from commit eea80b6) * fix: Create setUpClass (cherry picked from commit efac7b0) * fix: Add test for consumption of serialized Assets (cherry picked from commit 6b75d14) * fix: Remove unused import (cherry picked from commit b28f137) * fix: Change order of import statements (cherry picked from commit c94f1ed) * Merge pull request frappe#29257 from marination/fix-reset-wh-defaults fix: Avoid resetting Default wh fields for Manufacture Entry (cherry picked from commit efcfb82) Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Marica <maricadsouza221197@gmail.com>

* feat: added QI link in Job Card Dashboard (backport frappe#28643) * feat: Show Zero Values filter in consolidated financial statement (cherry picked from commit 9610086) * fix: ensure that reposting is finished before freezing stock/account (cherry picked from commit d37541d) * test: stock frozen validation (cherry picked from commit 75bc404) * fix: incorrect outgoing rates when material_consumption enabled (cherry picked from commit 7f3e6d1) * test: added tests for manufacture stock entry when material_consumption is enabled (cherry picked from commit 35346de) * fix: actual tax conversion in case of multicurrency invoices (backport frappe#28539) * fix: Shipping Rule picking up old net_rate (cherry picked from commit c78b8b7) * fix: calling shipping rule method during net_total calculation in taxes_adn_totals.py (cherry picked from commit 18ae03d) * fix: check if shipping rule value exists (cherry picked from commit af1fce0) * fix: fixed tests, separated a method for shipping charges (cherry picked from commit a8e2c02) * fix: sider issues (cherry picked from commit e7b4204) * fix: merge conflicts * fix: Paid showing in AR/AP report * fix: Better Error logging fordeferred revenue/expense booking (cherry picked from commit 67a001d) * fix: Commit joural entries (cherry picked from commit 0ba4fce) * fix: Log error before throwing exception (cherry picked from commit 3c64e20) * fix: mapping to maintenance visit gets erased (backport frappe#28917) * fix: ignore mandatory fields while creating WO from SO (backport frappe#28772) * refactor: map serial from schedule if only one (backport frappe#28745) * fix: TDS Monthly payable report (backport frappe#28764) * fix: Maintenance Visit purposes tables is not visible on submission (backport frappe#28792) * fix: misleading "Set Default X" fields after saving (backport frappe#28798) * fix: Fix depreciation_amount calculation (cherry picked from commit 22cc8d2) # Conflicts: # erpnext/regional/india/utils.py * fix: Create Depreciation Schedules properly for existing Assets (cherry picked from commit 5c3d4ca) * fix: Modify has_pro_rata() to include existing assets (cherry picked from commit de00200) * fix: Test if depreciation schedules are set up properly for existing assets (cherry picked from commit 774ac85) # Conflicts: # erpnext/assets/doctype/asset/test_asset.py * fix: Remove unnecessary variable (cherry picked from commit 828769c) * fix: conflicts * fix: conflicts * feat: Add Serial No field (cherry picked from commit 1aed8c4) * fix: Rename item to item_code (cherry picked from commit abb5355) * feat: Add 'Add Serial No' button in the Stock Items table (cherry picked from commit 4668bb4) * fix: Add serial no to Stock Entry doc to decrease quantity for Stock Items consumed during repair (cherry picked from commit 1393f97) * fix: Replace 'item' with 'item_code' in tests (cherry picked from commit c9e79ef) * fix: Create stock item (cherry picked from commit eea80b6) * fix: Create setUpClass (cherry picked from commit efac7b0) * fix: Add test for consumption of serialized Assets (cherry picked from commit 6b75d14) * fix: Remove unused import (cherry picked from commit b28f137) * fix: Change order of import statements (cherry picked from commit c94f1ed) * Merge pull request frappe#29257 from marination/fix-reset-wh-defaults fix: Avoid resetting Default wh fields for Manufacture Entry (cherry picked from commit efcfb82) Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Marica <maricadsouza221197@gmail.com>

* feat: added QI link in Job Card Dashboard (backport frappe#28643) * feat: Show Zero Values filter in consolidated financial statement (cherry picked from commit 9610086) * fix: ensure that reposting is finished before freezing stock/account (cherry picked from commit d37541d) * test: stock frozen validation (cherry picked from commit 75bc404) * fix: incorrect outgoing rates when material_consumption enabled (cherry picked from commit 7f3e6d1) * test: added tests for manufacture stock entry when material_consumption is enabled (cherry picked from commit 35346de) * fix: actual tax conversion in case of multicurrency invoices (backport frappe#28539) * fix: Shipping Rule picking up old net_rate (cherry picked from commit c78b8b7) * fix: calling shipping rule method during net_total calculation in taxes_adn_totals.py (cherry picked from commit 18ae03d) * fix: check if shipping rule value exists (cherry picked from commit af1fce0) * fix: fixed tests, separated a method for shipping charges (cherry picked from commit a8e2c02) * fix: sider issues (cherry picked from commit e7b4204) * fix: merge conflicts * fix: Paid showing in AR/AP report * fix: Better Error logging fordeferred revenue/expense booking (cherry picked from commit 67a001d) * fix: Commit joural entries (cherry picked from commit 0ba4fce) * fix: Log error before throwing exception (cherry picked from commit 3c64e20) * fix: mapping to maintenance visit gets erased (backport frappe#28917) * fix: ignore mandatory fields while creating WO from SO (backport frappe#28772) * refactor: map serial from schedule if only one (backport frappe#28745) * fix: TDS Monthly payable report (backport frappe#28764) * fix: Maintenance Visit purposes tables is not visible on submission (backport frappe#28792) * fix: misleading "Set Default X" fields after saving (backport frappe#28798) * fix: Fix depreciation_amount calculation (cherry picked from commit 22cc8d2) * fix: Create Depreciation Schedules properly for existing Assets (cherry picked from commit 5c3d4ca) * fix: Modify has_pro_rata() to include existing assets (cherry picked from commit de00200) * fix: Test if depreciation schedules are set up properly for existing assets (cherry picked from commit 774ac85) * fix: Remove unnecessary variable (cherry picked from commit 828769c) * fix: conflicts * fix: conflicts * feat: Add Serial No field (cherry picked from commit 1aed8c4) * fix: Rename item to item_code (cherry picked from commit abb5355) * feat: Add 'Add Serial No' button in the Stock Items table (cherry picked from commit 4668bb4) * fix: Add serial no to Stock Entry doc to decrease quantity for Stock Items consumed during repair (cherry picked from commit 1393f97) * fix: Replace 'item' with 'item_code' in tests (cherry picked from commit c9e79ef) * fix: Create stock item (cherry picked from commit eea80b6) * fix: Create setUpClass (cherry picked from commit efac7b0) * fix: Add test for consumption of serialized Assets (cherry picked from commit 6b75d14) * fix: Remove unused import (cherry picked from commit b28f137) * fix: Change order of import statements (cherry picked from commit c94f1ed) * Merge pull request frappe#29257 from marination/fix-reset-wh-defaults fix: Avoid resetting Default wh fields for Manufacture Entry (cherry picked from commit efcfb82) Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: GangaManoj <ganga.manoj98@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Marica <maricadsouza221197@gmail.com>

feat: added QI link in Job Card Dashboard

73894d5

noahjacob requested review from ankush, marination and rohitwaghchaure as code owners November 30, 2021 09:25

noahjacob added the backport version-13-hotfix label Nov 30, 2021

sharmanakul added this to the v13.17 milestone Dec 7, 2021

ankush approved these changes Dec 9, 2021

View reviewed changes

ankush merged commit f1c0190 into frappe:develop Dec 9, 2021

mergify bot pushed a commit that referenced this pull request Dec 9, 2021

feat: added QI link in Job Card Dashboard (#28643)

953e757

(cherry picked from commit f1c0190)

mergify bot mentioned this pull request Dec 9, 2021

feat: added QI link in Job Card Dashboard (backport #28643) #28810

Merged

ankush pushed a commit that referenced this pull request Dec 9, 2021

feat: added QI link in Job Card Dashboard (#28643) (#28810)

d2fac14

(cherry picked from commit f1c0190) Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>

rohitwaghchaure mentioned this pull request Dec 21, 2021

chore: change log for v13.17.0 #28989

Merged

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022

feat: added QI link in Job Card Dashboard (frappe#28643)

208d73a

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022

feat: added QI link in Job Card Dashboard (frappe#28643)

3bef1a7

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

fproldan added a commit to fproldan/erpnext that referenced this pull request Dec 15, 2022

feat: added QI link in Job Card Dashboard (backport frappe#28643)

544ca7e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added QI link in Job Card Dashboard #28643

feat: added QI link in Job Card Dashboard #28643

noahjacob commented Nov 30, 2021 •

edited

Loading

codecov bot commented Nov 30, 2021

feat: added QI link in Job Card Dashboard #28643

feat: added QI link in Job Card Dashboard #28643

Conversation

noahjacob commented Nov 30, 2021 • edited Loading

Changes

codecov bot commented Nov 30, 2021

Codecov Report

noahjacob commented Nov 30, 2021 •

edited

Loading