Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ledger merger #28812

Merged
merged 14 commits into from
Jan 2, 2022
Merged

feat: ledger merger #28812

merged 14 commits into from
Jan 2, 2022

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Dec 9, 2021

Ledger Merge aims to simplify the merging process of different accounts under the same root.
Current workflow is to open each account, click on the button, input the name and then merge.
This PR introduces a new doctype that lets the user easily merge multiple accounts.

Ledger.Merger.mp4
  • Ledger Merge doctype
  • Progress bar
  • Tests
  • Documentation

#no-docs (temp)

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #28812 (321730a) into develop (56b9ad8) will decrease coverage by 0.07%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop   #28812      +/-   ##
===========================================
- Coverage    55.68%   55.61%   -0.08%     
===========================================
  Files         1129     1131       +2     
  Lines        67471    67513      +42     
===========================================
- Hits         37574    37550      -24     
- Misses       29897    29963      +66     
Impacted Files Coverage Δ
...next/accounts/doctype/ledger_merge/ledger_merge.py 69.23% <69.23%> (ø)
...ype/ledger_merge_accounts/ledger_merge_accounts.py 100.00% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 93.33% <0.00%> (-3.34%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.93% <0.00%> (-2.74%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
... and 23 more

@rtdany10 rtdany10 marked this pull request as ready for review December 18, 2021 06:36
@deepeshgarg007 deepeshgarg007 merged commit 9c1773f into frappe:develop Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants