Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deferred Revenue and Expense report with actual and upcoming postings #28822

Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Dec 10, 2021

Deferred Revenue and Expense Report

This report aim to provide a simplified view of all deferred income/expense in a certain period. It can help in identifying the actual and expected posting.

Deferred Revenue

def_revenue

Deferred Expense

def_expense

Documentation

https://docs.erpnext.com/docs/v13/user/manual/en/accounts/deferred_revenue/expense_report

 - show deferred revenue and expense with actual and expected postings
 - unit tests added
@ruthra-kumar ruthra-kumar linked an issue Dec 10, 2021 that may be closed by this pull request
@ruthra-kumar ruthra-kumar marked this pull request as draft December 10, 2021 15:30
@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review December 14, 2021 07:18
for item in self.uniq_items:
self.items.append(Deferred_Item(item, self, [x for x in items if x.item == item]))

def get_postings(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a dead function, not called from anywhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

},
{
"fieldname" : "with_upcoming_postings",
"label": __("Show with upcoming revenue/expense"),
Copy link
Member

@deepeshgarg007 deepeshgarg007 Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also shows unbooked values for the previous months, may better to call this label as "Show expected revenue/expense" and this should be unchecked by default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.
Along with this, I think it's better if it only shows the actual posting(bar graph) when unchecked. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone wants to compare the expected and actual posting, how do they do that then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed and 'unchecked' by default.

@deepeshgarg007
Copy link
Member

Fix the linting issues

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@5c4d3f8). Click here to learn what that means.
The diff coverage is 61.61%.

@@            Coverage Diff             @@
##             develop   #28822   +/-   ##
==========================================
  Coverage           ?   55.54%           
==========================================
  Files              ?     1126           
  Lines              ?    67185           
  Branches           ?        0           
==========================================
  Hits               ?    37315           
  Misses             ?    29870           
  Partials           ?        0           
Impacted Files Coverage Δ
...evenue_and_expense/deferred_revenue_and_expense.py 61.61% <61.61%> (ø)

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 20, 2021
…-28822

feat: Deferred Revenue and Expense report with actual and upcoming postings (backport #28822)
@ruthra-kumar ruthra-kumar deleted the deferred_report_revenue_and_expense branch April 19, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferred Accounting Report for Income and Expenses
2 participants