-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deferred Revenue and Expense report with actual and upcoming postings #28822
feat: Deferred Revenue and Expense report with actual and upcoming postings #28822
Conversation
- show deferred revenue and expense with actual and expected postings - unit tests added
for item in self.uniq_items: | ||
self.items.append(Deferred_Item(item, self, [x for x in items if x.item == item])) | ||
|
||
def get_postings(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a dead function, not called from anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
}, | ||
{ | ||
"fieldname" : "with_upcoming_postings", | ||
"label": __("Show with upcoming revenue/expense"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also shows unbooked values for the previous months, may better to call this label as "Show expected revenue/expense" and this should be unchecked by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
Along with this, I think it's better if it only shows the actual posting(bar graph) when unchecked. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone wants to compare the expected and actual posting, how do they do that then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed and 'unchecked' by default.
Fix the linting issues |
- rename checkbox and make it - added translation text for labels - fixes for linter error
Codecov Report
@@ Coverage Diff @@
## develop #28822 +/- ##
==========================================
Coverage ? 55.54%
==========================================
Files ? 1126
Lines ? 67185
Branches ? 0
==========================================
Hits ? 37315
Misses ? 29870
Partials ? 0
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
…-28822 feat: Deferred Revenue and Expense report with actual and upcoming postings (backport #28822)
Deferred Revenue and Expense Report
This report aim to provide a simplified view of all deferred income/expense in a certain period. It can help in identifying the actual and expected posting.
Deferred Revenue
Deferred Expense
Documentation
https://docs.erpnext.com/docs/v13/user/manual/en/accounts/deferred_revenue/expense_report