Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new column 'Time taken to Deliver' in sales order analysis #28842

Merged
merged 4 commits into from
Dec 21, 2021

Conversation

ruthra-kumar
Copy link
Member

Current Report

'Sales Order Analysis' helps in quickly identifying billed amount, pending amount, delay in days and more information. Along with this a new column is added

New Column - 'Time taken to Deliver'

This denotes the no of days taken to completely deliver an item. This helps in identifying bottlenecks and get more efficient.

Image

time_taken_to_deliver

no-docs

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #28842 (8aa9481) into develop (92e86f2) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 8aa9481 differs from pull request most recent head da67403. Consider uploading reports for the commit da67403 to get more accurate results

@@             Coverage Diff             @@
##           develop   #28842      +/-   ##
===========================================
- Coverage    55.60%   55.54%   -0.06%     
===========================================
  Files         1128     1125       -3     
  Lines        67287    66984     -303     
===========================================
- Hits         37412    37205     -207     
+ Misses       29875    29779      -96     
Impacted Files Coverage Δ
...eport/sales_order_analysis/sales_order_analysis.py 0.00% <ø> (ø)
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-22.42%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-0.86%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.83% <0.00%> (-0.81%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 77.20% <0.00%> (-0.77%) ⬇️
erpnext/crm/doctype/lead/lead.py 64.46% <0.00%> (-0.71%) ⬇️
erpnext/accounts/deferred_revenue.py 75.43% <0.00%> (-0.44%) ⬇️
erpnext/stock/stock_ledger.py 85.21% <0.00%> (-0.37%) ⬇️
... and 23 more

@nextchamp-saqib nextchamp-saqib marked this pull request as ready for review December 15, 2021 05:06
@nextchamp-saqib nextchamp-saqib merged commit 9306873 into frappe:develop Dec 21, 2021
@marination
Copy link
Collaborator

marination commented Apr 14, 2022

@nextchamp-saqib @ruthra-kumar This report was introduced via #22055 to replace "Ordered Items to be Billed" and "Ordered Items to be Delivered and Billed"
The right join to DN makes it only fetch those transaction that have DNs against them, it does not fetch SOs that are pending to Deliver and Bill
It could use a test too, given that this could have been identified by CI

Also this column is a bit confusing with the Delay column, this needs documentation too https://docs.erpnext.com/docs/v13/user/manual/en/selling/sales-analytics

@ruthra-kumar
Copy link
Member Author

@marination thanks for reporting this. Will create a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include column for 'Days taken to deliver' in Sales Order Analysis Report
3 participants