-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update_serial_no function for old Maintenance Visits #28843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahjacob
requested review from
marination and
rohitwaghchaure
as code owners
December 13, 2021 11:32
Codecov Report
@@ Coverage Diff @@
## develop #28843 +/- ##
===========================================
+ Coverage 57.96% 58.05% +0.08%
===========================================
Files 1110 1110
Lines 68080 68088 +8
===========================================
+ Hits 39464 39528 +64
+ Misses 28616 28560 -56
|
noahjacob
force-pushed
the
maint_sch_link_fix
branch
from
December 14, 2021 06:27
4cc9c8e
to
4ff4d1b
Compare
ankush
reviewed
Dec 14, 2021
erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.py
Outdated
Show resolved
Hide resolved
noahjacob
force-pushed
the
maint_sch_link_fix
branch
from
December 15, 2021 07:25
3029906
to
972be87
Compare
noahjacob
force-pushed
the
maint_sch_link_fix
branch
from
December 15, 2021 09:58
972be87
to
c872aa4
Compare
noahjacob
added
backport version-13-hotfix
and removed
needs-tests
This PR needs automated unit-tests.
labels
Dec 17, 2021
noahjacob
force-pushed
the
maint_sch_link_fix
branch
from
December 17, 2021 08:17
95c30b9
to
b98c61f
Compare
ankush
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
January 12, 2022 14:16
marination
reviewed
Jan 17, 2022
erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.py
Outdated
Show resolved
Hide resolved
marination
reviewed
Jan 17, 2022
noahjacob
force-pushed
the
maint_sch_link_fix
branch
from
January 17, 2022 13:02
11a4d66
to
dec7513
Compare
marination
approved these changes
Jan 19, 2022
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Jan 19, 2022
…-28843 refactor: update_serial_no function for old Maintenance Visits (backport #28843)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix
maintenance_schedule
field in "Maintenance Visit" to fetch the serial nos instead of the Maintenance Schedule Detail row id, which isn't possible to identify on old docs.prevdoc_docname
.To Test: